* Two ob-lua versions
@ 2018-02-11 4:20 Thibault Marin
2018-02-11 9:22 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Thibault Marin @ 2018-02-11 4:20 UTC (permalink / raw)
To: emacs-org list
Hi maintainers,
I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
Since there is already an ob-lua.el in lisp/, I was wondering if the new
version was adding functionality not supported by the one in lisp/ (it
does not seem to be the case on casual inspection) and if so, whether
they could/should be merged.
Thanks,
thibault
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Two ob-lua versions
2018-02-11 4:20 Two ob-lua versions Thibault Marin
@ 2018-02-11 9:22 ` Nicolas Goaziou
2018-02-14 1:28 ` Satoru KURASHIKI
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2018-02-11 9:22 UTC (permalink / raw)
To: Thibault Marin; +Cc: emacs-org list
Hello,
Thibault Marin <thibault.marin@gmx.com> writes:
> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
> Since there is already an ob-lua.el in lisp/, I was wondering if the new
> version was adding functionality not supported by the one in lisp/ (it
> does not seem to be the case on casual inspection) and if so, whether
> they could/should be merged.
I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
can have some insight about it.
stardiviner, would you mind explaining why you need to create an
"ob-lua.el" library in "contrib/" ?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Two ob-lua versions
2018-02-11 9:22 ` Nicolas Goaziou
@ 2018-02-14 1:28 ` Satoru KURASHIKI
2018-02-14 10:18 ` numbchild
0 siblings, 1 reply; 5+ messages in thread
From: Satoru KURASHIKI @ 2018-02-14 1:28 UTC (permalink / raw)
To: emacs-org list
hi,
On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Thibault Marin <thibault.marin@gmx.com> writes:
>
>> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
>> Since there is already an ob-lua.el in lisp/, I was wondering if the new
>> version was adding functionality not supported by the one in lisp/ (it
>> does not seem to be the case on casual inspection) and if so, whether
>> they could/should be merged.
>
> I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
> can have some insight about it.
Anyway this breaks installation with package.el in org-plus-contrib case.
because of conflicting "ob-lua.el" filename.
> stardiviner, would you mind explaining why you need to create an
> "ob-lua.el" library in "contrib/" ?
It has to be fixed, so please revert that merge, until stardiviner will notice
this thread and retry PR...
regards,
--
KURASHIKI Satoru
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Two ob-lua versions
2018-02-14 1:28 ` Satoru KURASHIKI
@ 2018-02-14 10:18 ` numbchild
2018-02-14 10:29 ` numbchild
0 siblings, 1 reply; 5+ messages in thread
From: numbchild @ 2018-02-14 10:18 UTC (permalink / raw)
To: Satoru KURASHIKI; +Cc: emacs-org list
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
Hi, sorry for this. I have not noticed that. I will create an PR to remove
my `ob-lua.el` as soon as fast.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <lurdan@gmail.com> wrote:
> hi,
>
> On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
> > Hello,
> >
> > Thibault Marin <thibault.marin@gmx.com> writes:
> >
> >> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
> >> Since there is already an ob-lua.el in lisp/, I was wondering if the new
> >> version was adding functionality not supported by the one in lisp/ (it
> >> does not seem to be the case on casual inspection) and if so, whether
> >> they could/should be merged.
> >
> > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
> > can have some insight about it.
>
> Anyway this breaks installation with package.el in org-plus-contrib case.
> because of conflicting "ob-lua.el" filename.
>
> > stardiviner, would you mind explaining why you need to create an
> > "ob-lua.el" library in "contrib/" ?
>
> It has to be fixed, so please revert that merge, until stardiviner will
> notice
> this thread and retry PR...
>
> regards,
> --
> KURASHIKI Satoru
>
>
[-- Attachment #2: Type: text/html, Size: 2464 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Two ob-lua versions
2018-02-14 10:18 ` numbchild
@ 2018-02-14 10:29 ` numbchild
0 siblings, 0 replies; 5+ messages in thread
From: numbchild @ 2018-02-14 10:29 UTC (permalink / raw)
To: Satoru KURASHIKI; +Cc: emacs-org list
[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]
I created a PR now https://code.orgmode.org/bzg/org-mode/pulls/4 . Really
sorry for this. @Nicolas , can you merge it now?
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Feb 14, 2018 at 6:18 PM, numbchild@gmail.com <numbchild@gmail.com>
wrote:
> Hi, sorry for this. I have not noticed that. I will create an PR to remove
> my `ob-lua.el` as soon as fast.
>
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter: @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
> On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <lurdan@gmail.com>
> wrote:
>
>> hi,
>>
>> On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>> > Hello,
>> >
>> > Thibault Marin <thibault.marin@gmx.com> writes:
>> >
>> >> I noticed that a recent change added an ob-lua.el file to
>> contrib/lisp/.
>> >> Since there is already an ob-lua.el in lisp/, I was wondering if the
>> new
>> >> version was adding functionality not supported by the one in lisp/ (it
>> >> does not seem to be the case on casual inspection) and if so, whether
>> >> they could/should be merged.
>> >
>> > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
>> > can have some insight about it.
>>
>> Anyway this breaks installation with package.el in org-plus-contrib case.
>> because of conflicting "ob-lua.el" filename.
>>
>> > stardiviner, would you mind explaining why you need to create an
>> > "ob-lua.el" library in "contrib/" ?
>>
>> It has to be fixed, so please revert that merge, until stardiviner will
>> notice
>> this thread and retry PR...
>>
>> regards,
>> --
>> KURASHIKI Satoru
>>
>>
>
[-- Attachment #2: Type: text/html, Size: 3701 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-14 10:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-11 4:20 Two ob-lua versions Thibault Marin
2018-02-11 9:22 ` Nicolas Goaziou
2018-02-14 1:28 ` Satoru KURASHIKI
2018-02-14 10:18 ` numbchild
2018-02-14 10:29 ` numbchild
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).