emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Allen Li <vianchielfaura@gmail.com>
To: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [Bug] M-S Ret keybinding translated to M-Ret
Date: Fri, 09 Feb 2018 22:56:41 +0000	[thread overview]
Message-ID: <CAJr1M6fz8yNgv_6pcHV5MGOrnEm_ZgkQaEUGzmgU4-zje=M5Gg@mail.gmail.com> (raw)
In-Reply-To: <87tvuqw6it.fsf@fastmail.fm>

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Thanks, your new patch looks acceptable to me.


On Fri, Feb 9, 2018 at 7:02 AM Matt Lundin <mdl@imapmail.org> wrote:

> Allen Li <vianchielfaura@gmail.com> writes:
>
> > On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin <mdl@imapmail.org> wrote:
> >
> >> Matt Lundin <mdl@imapmail.org> writes:
> >
> >> > I discovered that when trying to insert a new item with a checkbox
> using
> >> > M-S Return (org-insert-todo-heading), the keybinding is "translated"
> to
> >> > M-Return (org-meta-return). As a result, all I get is simple list item
> >> > without a checkbox.
> >> >
> >
> >> The attached patch fixes this issue.
> >
> > I'm pretty sure your patch would break those binding in terminal Emacs
> > completely, since <return> cannot be typed in the terminal and Emacs
> > does not remap these bindings.
>
> Attached please find a more limited patch that fixes the issue in the
> GUI without affecting TTY use. I have only changed bindings for the
> M-S-RET or S-RET combinations. These combinations cannot be used in the
> TTY anyway and Org Mode already defines alternative TTY bindings for
> these combinations.
>
> Best,
> Matt
>
>

[-- Attachment #2: Type: text/html, Size: 1741 bytes --]

next prev parent reply	other threads:[~2018-02-09 22:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 20:54 [Bug] M-S Ret keybinding translated to M-Ret Matt Lundin
2018-02-07 21:46 ` Matt Lundin
2018-02-08  5:06   ` Allen Li
2018-02-08 23:51     ` Matt Lundin
2018-02-09 15:02     ` Matt Lundin
2018-02-09 22:56       ` Allen Li [this message]
2018-02-10 12:53       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJr1M6fz8yNgv_6pcHV5MGOrnEm_ZgkQaEUGzmgU4-zje=M5Gg@mail.gmail.com' \
    --to=vianchielfaura@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).