emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Matt Lundin <mdl@imapmail.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [Bug] M-S Ret keybinding translated to M-Ret
Date: Thu, 08 Feb 2018 17:51:32 -0600	[thread overview]
Message-ID: <871shv9h17.fsf@fastmail.fm> (raw)
In-Reply-To: <CAJr1M6fSBVid8yGUWFMwiLmo3eqhaOGQqZMu+4v0nt52ychB0Q@mail.gmail.com> (Allen Li's message of "Thu, 08 Feb 2018 05:06:00 +0000")

Allen Li <vianchielfaura@gmail.com> writes:

> On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin <mdl@imapmail.org> wrote:
>
>> Matt Lundin <mdl@imapmail.org> writes:
>
>> > I discovered that when trying to insert a new item with a checkbox using
>> > M-S Return (org-insert-todo-heading), the keybinding is "translated" to
>> > M-Return (org-meta-return). As a result, all I get is simple list item
>> > without a checkbox.
>> >
>
>> The attached patch fixes this issue.
>
> I'm pretty sure your patch would break those binding in terminal Emacs
> completely, since <return>
> cannot be typed in the terminal and Emacs does not remap these
> bindings.

Thanks for pointing this out. I hope someone who knows emacs keybindings
better can take the lead here. I was just following the example of the
following commit, which uses "<return>".

,----
| commit c3fffcd8d21f248f946e2d39d4bde3ce80dcf6d4
| Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
| Date:   Mon Jan 15 22:59:40 2018 +0100
| 
|     Fix C-<return> binding
`----

> Furthermore, I cannot reproduce your issue on Org mode version 9.1.6
> (9.1.6-33-g5b4a71-elpaplus)

That is because the version in elpa not have the problematic commit yet.
The elpa version you are using still uses old way of defining these
keys:

(org-defkey org-mode-map [(meta shift return)] 'org-insert-todo-heading)

The problematic commit (6965098a5357b09575a1119074545eb708cf5944)
changed that line to the following (along with several related changes):

(org-defkey org-mode-map (kbd "M-S-RET") #'org-insert-todo-heading)

Could you evaluate this latter line and see if you can reproduce the
problem.

Thanks,
Matt

next prev parent reply	other threads:[~2018-02-08 23:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 20:54 [Bug] M-S Ret keybinding translated to M-Ret Matt Lundin
2018-02-07 21:46 ` Matt Lundin
2018-02-08  5:06   ` Allen Li
2018-02-08 23:51     ` Matt Lundin [this message]
2018-02-09 15:02     ` Matt Lundin
2018-02-09 22:56       ` Allen Li
2018-02-10 12:53       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871shv9h17.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).