From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Lundin <mdl@imapmail.org>
Subject: Re: [Bug] M-S Ret keybinding translated to M-Ret
Date: Thu, 08 Feb 2018 17:51:32 -0600
Message-ID: <871shv9h17.fsf@fastmail.fm>
References: <87shad3kll.fsf@fastmail.fm> <878tc4iibv.fsf@fastmail.fm>
	<CAJr1M6fSBVid8yGUWFMwiLmo3eqhaOGQqZMu+4v0nt52ychB0Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdl@imapmail.org>) id 1ejvya-0003ac-BH
	for emacs-orgmode@gnu.org; Thu, 08 Feb 2018 18:51:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdl@imapmail.org>) id 1ejvyW-0003ko-9C
	for emacs-orgmode@gnu.org; Thu, 08 Feb 2018 18:51:36 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38197)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mdl@imapmail.org>) id 1ejvyV-0003kN-Qf
	for emacs-orgmode@gnu.org; Thu, 08 Feb 2018 18:51:32 -0500
In-Reply-To: <CAJr1M6fSBVid8yGUWFMwiLmo3eqhaOGQqZMu+4v0nt52ychB0Q@mail.gmail.com>
	(Allen Li's message of "Thu, 08 Feb 2018 05:06:00 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>

Allen Li <vianchielfaura@gmail.com> writes:

> On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin <mdl@imapmail.org> wrote:
>
>> Matt Lundin <mdl@imapmail.org> writes:
>
>> > I discovered that when trying to insert a new item with a checkbox using
>> > M-S Return (org-insert-todo-heading), the keybinding is "translated" to
>> > M-Return (org-meta-return). As a result, all I get is simple list item
>> > without a checkbox.
>> >
>
>> The attached patch fixes this issue.
>
> I'm pretty sure your patch would break those binding in terminal Emacs
> completely, since <return>
> cannot be typed in the terminal and Emacs does not remap these
> bindings.

Thanks for pointing this out. I hope someone who knows emacs keybindings
better can take the lead here. I was just following the example of the
following commit, which uses "<return>".

,----
| commit c3fffcd8d21f248f946e2d39d4bde3ce80dcf6d4
| Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
| Date:   Mon Jan 15 22:59:40 2018 +0100
| 
|     Fix C-<return> binding
`----

> Furthermore, I cannot reproduce your issue on Org mode version 9.1.6
> (9.1.6-33-g5b4a71-elpaplus)

That is because the version in elpa not have the problematic commit yet.
The elpa version you are using still uses old way of defining these
keys:

(org-defkey org-mode-map [(meta shift return)] 'org-insert-todo-heading)

The problematic commit (6965098a5357b09575a1119074545eb708cf5944)
changed that line to the following (along with several related changes):

(org-defkey org-mode-map (kbd "M-S-RET") #'org-insert-todo-heading)

Could you evaluate this latter line and see if you can reproduce the
problem.

Thanks,
Matt