From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Li Subject: Re: [Bug] M-S Ret keybinding translated to M-Ret Date: Fri, 09 Feb 2018 22:56:41 +0000 Message-ID: References: <87shad3kll.fsf@fastmail.fm> <878tc4iibv.fsf@fastmail.fm> <87tvuqw6it.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c12a7b8b66f6c0564cf71b8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekHbD-0006U5-NX for emacs-orgmode@gnu.org; Fri, 09 Feb 2018 17:56:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekHbC-00075d-Ti for emacs-orgmode@gnu.org; Fri, 09 Feb 2018 17:56:55 -0500 Received: from mail-qt0-x233.google.com ([2607:f8b0:400d:c0d::233]:41475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekHbC-00074u-OA for emacs-orgmode@gnu.org; Fri, 09 Feb 2018 17:56:54 -0500 Received: by mail-qt0-x233.google.com with SMTP id a9so5958850qtj.8 for ; Fri, 09 Feb 2018 14:56:53 -0800 (PST) In-Reply-To: <87tvuqw6it.fsf@fastmail.fm> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode List --94eb2c12a7b8b66f6c0564cf71b8 Content-Type: text/plain; charset="UTF-8" Thanks, your new patch looks acceptable to me. On Fri, Feb 9, 2018 at 7:02 AM Matt Lundin wrote: > Allen Li writes: > > > On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin wrote: > > > >> Matt Lundin writes: > > > >> > I discovered that when trying to insert a new item with a checkbox > using > >> > M-S Return (org-insert-todo-heading), the keybinding is "translated" > to > >> > M-Return (org-meta-return). As a result, all I get is simple list item > >> > without a checkbox. > >> > > > > >> The attached patch fixes this issue. > > > > I'm pretty sure your patch would break those binding in terminal Emacs > > completely, since cannot be typed in the terminal and Emacs > > does not remap these bindings. > > Attached please find a more limited patch that fixes the issue in the > GUI without affecting TTY use. I have only changed bindings for the > M-S-RET or S-RET combinations. These combinations cannot be used in the > TTY anyway and Org Mode already defines alternative TTY bindings for > these combinations. > > Best, > Matt > > --94eb2c12a7b8b66f6c0564cf71b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, your new patch looks acceptable to me.

On Fri, Feb 9, 2018 at 7:02 A= M Matt Lundin <mdl@imapmail.org&= gt; wrote:
Allen Li <vianchielfaura@gmail.com= > writes:

> On Wed, Feb 7, 2018 at 1:47 PM Matt Lundin <mdl@imapmail.org> wrote:
>
>> Matt Lundin <mdl@imapmail.org> writes:
>
>> > I discovered that when trying to insert a new item with a che= ckbox using
>> > M-S Return (org-insert-todo-heading), the keybinding is "= ;translated" to
>> > M-Return (org-meta-return). As a result, all I get is simple = list item
>> > without a checkbox.
>> >
>
>> The attached patch fixes this issue.
>
> I'm pretty sure your patch would break those binding in terminal E= macs
> completely, since <return> cannot be typed in the terminal and E= macs
> does not remap these bindings.

Attached please find a more limited patch that fixes the issue in the
GUI without affecting TTY use. I have only changed bindings for the
M-S-RET or S-RET combinations. These combinations cannot be used in the
TTY anyway and Org Mode already defines alternative TTY bindings for
these combinations.

Best,
Matt

--94eb2c12a7b8b66f6c0564cf71b8--