emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Samuel Wales <samologist@gmail.com>
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-mouse is activated without explicit require
Date: Sat, 10 Dec 2022 21:38:55 -0700	[thread overview]
Message-ID: <CAJcAo8uo+e1_-PfOc0+LAow15dB3QaCzGyv2qxv=v_wm6_6ZzQ@mail.gmail.com> (raw)
In-Reply-To: <87r0x6sju1.fsf@fastmail.fm>

hi matt,

superb bug report.  happy human rights day.

isn't there a policy someplace in the elisp manual that states that
loading a package should have no major[tm] side effects?

the emacs behavior of loading upon completion is new to me and a
surprise.  the org list of links behavior is new to me.

n.b. i personally find org-mouse to a be excellent for accessibility
reasons.  i am always either in mouse mode or keyboard mode and it
adds a lot of functionality.  could even use a bit more, such as
selecting todo kw.

sorry cannot address your bug further.  it does seem there are things
needing fixing.

On 12/10/22, Matt Lundin <mdl@imapmail.org> wrote:
> I'm not too familiar with how emacs handles autoloads. However, I find
> org-mouse is automatically loaded if I call describe-function and then
> tab complete after typing "", "org-", "org-m", etc. This seems enough to
> load the entirely of the org-mouse.el file.
> The problem is that this adds a lambda function to org-mode-hook that
> activates all org-mouse functionality at the next call of org-mode or
> org-mode-restart. This has two unexpected effects:
> 1. It changes the behavior of mouse clicks without the user's explicit
>    request.
> 2. It advise org-open-at-point, with the result that it is no longer
>    possible to get a list of all links in an entry when calling
>    org-open-at-point on a headline. (See separate bug report on this.)
> I am able to reproduce this with a minimal .emacs config and the most
> recent git version (after running "make clean && make").
> Steps to reproduce:
> 1. /usr/bin/emacs -Q -l ~/minimal.el
> where ~/minimal.el is...
> --8<---------------cut here---------------start------------->8---
> (add-to-list 'load-path "~/org-mode/lisp/")
> --8<---------------cut here---------------end--------------->8---
> 2. C-h f org-m [tab]
> Note that "org-mouse-" functions appear in the completion list. Even if
> one aborts describe-function at this point, org-mouse has been loaded
> and org-mode-hook now contains a lambda function to activate the
> functionality of org-mouse (org-defkey, advice-add, etc.).
> 3. Open an org buffer for the first time or call "M-x org-mode-restart"
>    in an already opened buffer
> "C-h v org-open-at-point" now reports the following advice:
> --8<---------------cut here---------------start------------->8---
> This function has :around advice: ‘org--mouse-open-at-point’.
> --8<---------------cut here---------------end--------------->8---
> Also notice that org-mouse features are now active in org buffers.
> Thanks,
> Matt

The Kafka Pandemic

A blog about science, health, human rights, and misopathy:

  parent reply	other threads:[~2022-12-11  4:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  3:25 [BUG] org-mouse is activated without explicit require Matt Lundin
2022-12-11  3:49 ` Greg Minshall
2022-12-11  4:38 ` Samuel Wales [this message]
2022-12-11  9:45 ` Ihor Radchenko
2022-12-11 14:49   ` Autoloading side effects (was: Re: [BUG] org-mouse is activated without explicit require) Max Nikulin
2022-12-12 10:25     ` Ihor Radchenko
2022-12-12 16:20       ` Max Nikulin
2022-12-13  9:52         ` Ihor Radchenko
2022-12-13 14:32           ` [BUG] org-mouse is activated without explicit require Max Nikulin
2022-12-14  9:59             ` Ihor Radchenko
2022-12-12 15:42     ` Autoloading side effects (was: Re: [BUG] org-mouse is activated without explicit require) Matt Lundin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJcAo8uo+e1_-PfOc0+LAow15dB3QaCzGyv2qxv=v_wm6_6ZzQ@mail.gmail.com' \
    --to=samologist@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).