From: Matt Lundin <mdl@imapmail.org>
To: Max Nikulin <manikulin@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Autoloading side effects (was: Re: [BUG] org-mouse is activated without explicit require)
Date: Mon, 12 Dec 2022 09:42:58 -0600 [thread overview]
Message-ID: <87a63smxvh.fsf@fastmail.fm> (raw)
In-Reply-To: <tn4ql0$bu2$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> I am afraid, requirement that loading should not cause side effects is
> too strict and it will make usage inconvenient. Examples:
> - ol-info calls `org-link-set-parameters'.
> - org-protocol installs an advice for `server-visit-files'. (It should
> not be necessary, but currently Emacs does not provide a better option.)
>
> However I agree that it is undesired when attempt to call interactive
> help causes side effects. I would say that in such cases loading of
> packages should be sandboxed and should not propagate to global scope.
For reference, another module that causes global side effects when
calling interactive help is org-ctags.el. It advises `visit-tags-table`
and `xref-find-definitions` and adds a hook to `org-mode-hook`.
Matt
prev parent reply other threads:[~2022-12-12 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 3:25 [BUG] org-mouse is activated without explicit require Matt Lundin
2022-12-11 3:49 ` Greg Minshall
2022-12-11 4:38 ` Samuel Wales
2022-12-11 9:45 ` Ihor Radchenko
2022-12-11 14:49 ` Autoloading side effects (was: Re: [BUG] org-mouse is activated without explicit require) Max Nikulin
2022-12-12 10:25 ` Ihor Radchenko
2022-12-12 16:20 ` Max Nikulin
2022-12-13 9:52 ` Ihor Radchenko
2022-12-13 14:32 ` [BUG] org-mouse is activated without explicit require Max Nikulin
2022-12-14 9:59 ` Ihor Radchenko
2022-12-12 15:42 ` Matt Lundin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a63smxvh.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).