emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jay McCarthy <jay.mccarthy@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Faces interaction between org-mode and emacs24
Date: Mon, 20 Aug 2012 09:22:02 -0600	[thread overview]
Message-ID: <CAJYbDanKb=ShQvu5hzw_iBn9D=C6y9f2zAMNz=6rB6N=4qMaeQ@mail.gmail.com> (raw)
In-Reply-To: <87393iud7m.fsf@altern.org>

[-- Attachment #1: Type: text/plain, Size: 2418 bytes --]

Yes, it was under column mode.

I tried in vain to make a small example but my emacs-fu is not strong
enough. Attached is what I started to do...

Jay

On Sun, Aug 19, 2012 at 9:13 AM, Bastien <bzg@altern.org> wrote:
> Hi Jay,
>
> Jay McCarthy <jay.mccarthy@gmail.com> writes:
>
>> I recently upgraded from emacs23 to emacs24, using the current git
>> version of org-mode with both (current = e4c4d85). I am now
>> experiencing something odd.
>>
>> If I open up the org-agenda to see my TODOs, the node titles are
>> colored one way (red for late, gray for future, etc). I have this
>> color setup using the org-agenda-before-sorting-filter-function
>> variable, it basically looks at the deadline time and then calls
>> put-text-property to give the text a new 'face property. You can see
>> the code here:
>>
>> https://github.com/jeapostrophe/exp/blob/master/.emacs.el#L627 (it
>> goes to about line 736)
>>
>> This worked great in emacs23. But now with emacs24, the colors are
>> only correct when I first start emacs and load the agenda the first
>> time. If I ever go to visit a TODO item in the org buffer (for
>> example, by pressing <Tab>) then the color of the item from the org
>> buffer appears in the agenda. For example, if something is one level
>> deep (*) then it becomes blue-ish, even though my filtering function
>> has change the face to be red.
>
> I assume the above is with column-mode turned on, right?
>
> ...
>
>> If I put my cursor in the org-buffer on the item and describe its
>> text-properties, then I get the face to be, for example 'org-level-6,
>> but if I go to the org-agenda and put my cursor on the text, I see
>> that the face is 'due (what it is supposed to be)
>>
>> Even stranger, if I am in the org-agenda and turn OFF column mode
>> (org-columns), then I see the "correct" colors of all the items. It is
>> just in column mode that I see the colors from the org buffer.
>>
>> I was able to fix this with the following patch:
>
> ... otherwise I don't see why just fixing `org-columns-new-overlay'
> should fix the first situation you describe.
>
> I under the idea behind the patch but I'd like to make sure there is
> nothing more than this.  Perhaps a simple reproducible example?
>
> Thanks!
>
> --
>  Bastien



-- 
Jay McCarthy <jay@cs.byu.edu>
Assistant Professor / Brigham Young University
http://faculty.cs.byu.edu/~jay

"The glory of God is Intelligence" - D&C 93

[-- Attachment #2: faces.el --]
[-- Type: application/octet-stream, Size: 1131 bytes --]

(setq load-path (cons "~/Dev/dist/org-mode/lisp" load-path))
(setq load-path (cons "~/Dev/dist/org-mode/contrib/lisp" load-path))
(add-to-list 'Info-default-directory-list
             (expand-file-name "~/Dev/dist/org-mode/doc"))
(require 'org-install)
(require 'org)
(require 'org-faces)

(setq org-directory "~/Dev/dist/org-mode/errors/faces/")
(setq org-agenda-files (list org-directory))

(setq org-agenda-before-sorting-filter-function 'todo-colorize)
(setq org-agenda-custom-commands 
      '(("t" "Todo list" todo "TODO"
         ())))

(defface due
  (org-compatible-face 'default
    '((t (:foreground "#000000"))))
  "Face for due items"
  :group 'org-faces)
(set-face-foreground 'due "#dc322f")

(defun todo-colorize (a)
  (let* ()
    ;; Remove the TODO
    (put-text-property
     0 (length a)
     'txt
     (replace-regexp-in-string "^TODO *" "" (get-text-property 0 'txt a))
     a)

    ;; Remove the old face
    (remove-text-properties 0 (length a) '((face nil) (fontified nil)) a)

    ;; Put on the new face
    (put-text-property 0 (length a) 'face 'due a)

    a))

(org-agenda "" "t")
(org-agenda-columns)

[-- Attachment #3: faces.org --]
[-- Type: application/octet-stream, Size: 116 bytes --]

* TODO First
** TODO Second
*** TODO Third
**** TODO Fourth
***** TODO Fifth
****** TODO Sixth
******* TODO Seventh

  reply	other threads:[~2012-08-20 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18 17:24 Jay McCarthy
2012-08-19 15:13 ` Bastien
2012-08-20 15:22   ` Jay McCarthy [this message]
2012-08-21 18:10     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJYbDanKb=ShQvu5hzw_iBn9D=C6y9f2zAMNz=6rB6N=4qMaeQ@mail.gmail.com' \
    --to=jay.mccarthy@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).