emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jay McCarthy <jay.mccarthy@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Faces interaction between org-mode and emacs24
Date: Sat, 18 Aug 2012 11:24:58 -0600	[thread overview]
Message-ID: <CAJYbDanuh+DvpdtQUx6LowD_WFzvfwVjmsDjcaEAkgXgeehUkQ@mail.gmail.com> (raw)

I recently upgraded from emacs23 to emacs24, using the current git
version of org-mode with both (current = e4c4d85). I am now
experiencing something odd.

If I open up the org-agenda to see my TODOs, the node titles are
colored one way (red for late, gray for future, etc). I have this
color setup using the org-agenda-before-sorting-filter-function
variable, it basically looks at the deadline time and then calls
put-text-property to give the text a new 'face property. You can see
the code here:

https://github.com/jeapostrophe/exp/blob/master/.emacs.el#L627 (it
goes to about line 736)

This worked great in emacs23. But now with emacs24, the colors are
only correct when I first start emacs and load the agenda the first
time. If I ever go to visit a TODO item in the org buffer (for
example, by pressing <Tab>) then the color of the item from the org
buffer appears in the agenda. For example, if something is one level
deep (*) then it becomes blue-ish, even though my filtering function
has change the face to be red.

If I put my cursor in the org-buffer on the item and describe its
text-properties, then I get the face to be, for example 'org-level-6,
but if I go to the org-agenda and put my cursor on the text, I see
that the face is 'due (what it is supposed to be)

Even stranger, if I am in the org-agenda and turn OFF column mode
(org-columns), then I see the "correct" colors of all the items. It is
just in column mode that I see the colors from the org buffer.

I was able to fix this with the following patch:

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index ff75af6..bee908b 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -150,6 +150,8 @@ This is the compiled version of the format.")
   "Create a new column overlay and add it to the list."
   (let ((ov (make-overlay beg end)))
     (overlay-put ov 'face (or face 'secondary-selection))
+    (remove-text-properties
+         0 (length string) '(face nil) string)
     (org-overlay-display ov string face)
     (push ov org-columns-overlays)
     ov))

Basically, it removes whatever face was on the string that the column
is made out of before it creates the overlay, otherwise the face for
the column doesn't get applied.

I have no idea if this is a good solution overall, but I got it
work... and maybe others will have a similar problem.

Jay

--
Jay McCarthy <jay@cs.byu.edu>
Assistant Professor / Brigham Young University
http://faculty.cs.byu.edu/~jay

"The glory of God is Intelligence" - D&C 93

             reply	other threads:[~2012-08-18 17:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18 17:24 Jay McCarthy [this message]
2012-08-19 15:13 ` Bastien
2012-08-20 15:22   ` Jay McCarthy
2012-08-21 18:10     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJYbDanuh+DvpdtQUx6LowD_WFzvfwVjmsDjcaEAkgXgeehUkQ@mail.gmail.com \
    --to=jay.mccarthy@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).