From: Daniel F <difrumin@gmail.com>
To: "emacs-orgmode@gnu.org Mode" <emacs-orgmode@gnu.org>
Subject: Re: Skim.app support for org-mac-link-grabber.el
Date: Mon, 13 May 2013 13:53:08 +0400 [thread overview]
Message-ID: <CACxkR4COO3hbzmvnxhQYbz_X764DGcUcy1BbCA6tVwzDfa4S_w@mail.gmail.com> (raw)
In-Reply-To: <BBD5BBAC-DCFB-4478-B9A6-8DC20C875D7C@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2759 bytes --]
Hi Carsten, Ivan.
Thanks for the feedback. The issue that Ivan mentioned does look important
and I'll try to fix it asap and incorporate the check.
I'll also look into the rehilighting thing, I am not sure if that's
possible. I guess it also would be nice to scroll not just to the right
page, but also to the right line in the text.
As for the "as-" prefix I just assumed that this is legit because the
package was already present in the org-mode.
Cheers.
- Dan
On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik <carsten.dominik@gmail.com
> wrote:
> Hi Daniil,
>
> I like this a lot and would like to take the patch after you have taken
> Ivans feedback, and maybe more feedback if you get any.
>
> I would like it even more if following the link would rehighlight the
> selected text. Is there any way to achieve this?
>
> I have another question, this would maybe be for the original author,
> Anthony Lander? I see that there are functions with prefixes that are not
> "org-". This is dangerous because there might be packages around that use
> that name space. I also think it violates coding rules in Emacs. I think
> this should be changed - unless you know of a convention that all functions
> dealing with applescripts are supposed to have an "as-" prefix.
>
> I can fix this - but I wanted your feedback first.
>
> Thanks.
>
> - Carsten
>
> On 12 mei 2013, at 20:29, Daniil Frumin <difrumin@gmail.com> wrote:
>
> > Hi, all!
> >
> > I use org-mac-link-grabber.el <
> http://orgmode.org/worg/org-contrib/org-mac-link-grabber.html> almost
> every day. However, it lacks support for an app that I'd like to use
> together with org-mode.
> >
> > Skim.app is a light and fast PDF reader for Mac OS X with a note-taking
> ability. I wrote a little patch for org-mac-link-grabber.el to support
> grabbing links to documents.
> >
> > What it does:
> >
> > * Grabs not just the link to file, but a page
> >
> > * Inserts the selected text as a description, if present. Otherwise
> > inserts "<filename>, p. <page #>"
> >
> > * The shortcut is set to [S]
> >
> > * Defines a new "skim" link type
> >
> > It would be interesting to also add some support for importing notes
> from Skim to org.
> >
> > Since Skim.app is not present in clean OS X installs, by default support
> for grabbing links from it is disabled. You can enable it by customizing
> group `org-mac-link-grabber'.
> >
> > So, maybe it's possible to get this patch into the tree? It's my first
> time hacking on org (or even any major elisp extension), so it's probably
> that I've messed up somewhere with a commit format or whatnot.
> >
> > Cheers.
> >
> > -- Daniil Frumin
> > <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch>
>
>
--
Sincerely yours,
-- Daniil
[-- Attachment #2: Type: text/html, Size: 3738 bytes --]
next prev parent reply other threads:[~2013-05-13 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 18:29 Skim.app support for org-mac-link-grabber.el Daniil Frumin
2013-05-13 0:39 ` Ivan Andrus
2013-05-13 6:34 ` Carsten Dominik
2013-05-13 9:53 ` Daniel F [this message]
2013-05-13 10:54 ` Carsten Dominik
2013-05-13 20:35 ` Daniil Frumin
2013-05-14 4:33 ` Carsten Dominik
2013-05-14 6:18 ` Daniil Frumin
2013-05-14 7:12 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACxkR4COO3hbzmvnxhQYbz_X764DGcUcy1BbCA6tVwzDfa4S_w@mail.gmail.com \
--to=difrumin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).