From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel F Subject: Re: Skim.app support for org-mac-link-grabber.el Date: Mon, 13 May 2013 13:53:08 +0400 Message-ID: References: <171D50FA-314D-4233-9F7E-AD07D8B1B902@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c3c348e9b94304dc967ba5 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbpRR-00045N-Lw for emacs-orgmode@gnu.org; Mon, 13 May 2013 05:53:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbpRO-0006Q4-Fq for emacs-orgmode@gnu.org; Mon, 13 May 2013 05:53:13 -0400 Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:51633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbpRO-0006Po-3n for emacs-orgmode@gnu.org; Mon, 13 May 2013 05:53:10 -0400 Received: by mail-la0-f44.google.com with SMTP id fr10so873149lab.3 for ; Mon, 13 May 2013 02:53:09 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "emacs-orgmode@gnu.org Mode" --001a11c3c348e9b94304dc967ba5 Content-Type: text/plain; charset=ISO-8859-1 Hi Carsten, Ivan. Thanks for the feedback. The issue that Ivan mentioned does look important and I'll try to fix it asap and incorporate the check. I'll also look into the rehilighting thing, I am not sure if that's possible. I guess it also would be nice to scroll not just to the right page, but also to the right line in the text. As for the "as-" prefix I just assumed that this is legit because the package was already present in the org-mode. Cheers. - Dan On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik wrote: > Hi Daniil, > > I like this a lot and would like to take the patch after you have taken > Ivans feedback, and maybe more feedback if you get any. > > I would like it even more if following the link would rehighlight the > selected text. Is there any way to achieve this? > > I have another question, this would maybe be for the original author, > Anthony Lander? I see that there are functions with prefixes that are not > "org-". This is dangerous because there might be packages around that use > that name space. I also think it violates coding rules in Emacs. I think > this should be changed - unless you know of a convention that all functions > dealing with applescripts are supposed to have an "as-" prefix. > > I can fix this - but I wanted your feedback first. > > Thanks. > > - Carsten > > On 12 mei 2013, at 20:29, Daniil Frumin wrote: > > > Hi, all! > > > > I use org-mac-link-grabber.el < > http://orgmode.org/worg/org-contrib/org-mac-link-grabber.html> almost > every day. However, it lacks support for an app that I'd like to use > together with org-mode. > > > > Skim.app is a light and fast PDF reader for Mac OS X with a note-taking > ability. I wrote a little patch for org-mac-link-grabber.el to support > grabbing links to documents. > > > > What it does: > > > > * Grabs not just the link to file, but a page > > > > * Inserts the selected text as a description, if present. Otherwise > > inserts ", p. " > > > > * The shortcut is set to [S] > > > > * Defines a new "skim" link type > > > > It would be interesting to also add some support for importing notes > from Skim to org. > > > > Since Skim.app is not present in clean OS X installs, by default support > for grabbing links from it is disabled. You can enable it by customizing > group `org-mac-link-grabber'. > > > > So, maybe it's possible to get this patch into the tree? It's my first > time hacking on org (or even any major elisp extension), so it's probably > that I've messed up somewhere with a commit format or whatnot. > > > > Cheers. > > > > -- Daniil Frumin > > <0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch> > > -- Sincerely yours, -- Daniil --001a11c3c348e9b94304dc967ba5 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Carsten, Ivan.

Thanks for the feedba= ck. The issue that Ivan mentioned does look important and I'll try to f= ix it asap and incorporate the check.
I'll also look in= to the rehilighting thing, I am not sure if that's possible. I guess it= also would be nice to scroll not just to the right page, but also to the r= ight line in the text.

As for the "as-" prefix I just as= sumed that this is legit because the package was already present in the org= -mode.

Cheers.

- Dan


On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik <carsten.dominik@gmail.com> wrote:
Hi Daniil,

I like this a lot and would like to take the patch after you have taken Iva= ns feedback, and maybe more feedback if you get any.

I would like it even more if following the link would rehighlight the selec= ted text. =A0Is there any way to achieve this?

I have another question, this would maybe be for the original author, Antho= ny Lander? =A0I see that there are functions with prefixes that are not &qu= ot;org-". =A0This is dangerous because there might be packages around = that use that name space. =A0I also think it violates coding rules in Emacs= . =A0I think this should be changed - unless you know of a convention that = all functions dealing with applescripts are supposed to have an "as-&q= uot; prefix.

I can fix this - but I wanted your feedback first.

Thanks.

- Carsten

On 12 mei 2013, at 20:29, Daniil Frumin <difrumin@gmail.com> wrote:

> Hi, all!
>
> I use org-mac-link-grabber.el <http://orgmode.org/= worg/org-contrib/org-mac-link-grabber.html> almost every day. Howeve= r, it lacks support for an app that I'd like to use together with org-m= ode.
>
> Skim.app is a light and fast PDF reader for Mac OS X with a note-takin= g ability. I wrote a little patch for org-mac-link-grabber.el to support gr= abbing links to documents.
>
> What it does:
>
> * Grabs not just the link to file, but a page
>
> * Inserts the selected text as a description, if present. Otherwise > =A0inserts "<filename>, p. <page #>"
>
> * The shortcut is set to [S]
>
> * Defines a new "skim" link type
>
> It would be interesting to also add some support for importing notes f= rom Skim to org.
>
> Since Skim.app is not present in clean OS X installs, by default suppo= rt for grabbing links from it is disabled. You can enable it by customizing= group `org-mac-link-grabber'.
>
> So, maybe it's possible to get this patch into the tree? It's = my first time hacking on org (or even any major elisp extension), so it'= ;s probably that I've messed up somewhere with a commit format or whatn= ot.
>
> Cheers.
>
> -- Daniil Frumin
> <0001-Adding-Skim.app-support-to-org-mac-link-grabber.e= l.patch>




--
Sincerely yo= urs,
-- Daniil
--001a11c3c348e9b94304dc967ba5--