emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Andreas Seltenreich <seltenreich@gmx.de>
Cc: emacs-orgmode@gnu.org, 3597@emacsbugs.donarmstrong.com
Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros
Date: Wed, 24 Jun 2009 14:44:23 +0200	[thread overview]
Message-ID: <BBCF1CD7-EF89-470E-96EE-27EC0E0B7AE0@gmail.com> (raw)
In-Reply-To: <878wjhbyc1.fsf@gate450.dyndns.org>


On Jun 24, 2009, at 2:39 PM, Andreas Seltenreich wrote:

>
> [Sorry about setting Cc instead X-Debbugs-Cc and causing the duplicate
> report.  I set a proper Mail-Followup-To header now.]
>
> Carsten Dominik writes:
>
>> This looks to me as if it was a bug in keyboard macro execution,
>> which should call functions interactively.
>
> The docstring for interactive-p has the following paragraph:
>
> ,----[ C-h f interactive-p RET ]
> | The only known proper use of `interactive-p' is in deciding  
> whether to
> | display a helpful message, or how to display it.  If you're thinking
> | of using it for any other purpose, it is quite likely that you're
> | making a mistake.  Think: what do you want to do when the command is
> | called from a keyboard macro?
> `----
>
> The elisp reference states:
>
> ,----[ (info "(elisp)Distinguish Interactive") ]
> |  -- Function: interactive-p
> |      This function returns `t' if the containing function (the one
> |      whose code includes the call to `interactive-p') was called in
> |      direct response to user input.  This means that it was called  
> with
> |      the function `call-interactively', and that a keyboard macro is
> |      not running, and that Emacs is not running in batch mode.
> `----
>
> This sounds like interactive-p is working as documented and the
> excplicit check I proposed would be neccessary.

True enough, and I am applying your fix.

Thanks.

- Carsten

>
> Thanks,
> andreas

  reply	other threads:[~2009-06-24 12:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 11:15 Andreas Seltenreich
2009-06-24 12:17 ` Carsten Dominik
2009-06-24 12:39   ` Andreas Seltenreich
2009-06-24 12:44     ` Carsten Dominik [this message]
2009-06-27  0:43       ` bug#3597: [Orgmode] " Stefan Monnier
2009-06-27  9:38         ` bug#3597: " Carsten Dominik
2009-07-02  3:39     ` Samuel Wales
2009-07-02  5:52       ` Bastien
2009-07-02  6:05         ` Samuel Wales
2009-07-02  7:08           ` Bastien
2009-07-02 18:02             ` Samuel Wales
2009-07-03  9:18               ` Bastien
2009-07-26  0:44                 ` Samuel Wales
2011-03-03 21:15 ` bug#3597: " Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BBCF1CD7-EF89-470E-96EE-27EC0E0B7AE0@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=3597@emacsbugs.donarmstrong.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=seltenreich@gmx.de \
    --subject='Re: 23.0.94; [PATCH] org-store-link broken within kbd macros' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).