From: Carsten Dominik <carsten.dominik@gmail.com>
To: Andreas Seltenreich <seltenreich@gmx.de>
Cc: emacs-pretest-bug@gnu.org, emacs-orgmode@gnu.org
Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros
Date: Wed, 24 Jun 2009 14:17:59 +0200 [thread overview]
Message-ID: <8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com> (raw)
In-Reply-To: <87bponi011.fsf@gate450.dyndns.org>
This looks to me as if it was a bug in keyboard macro execution,
which should call functions interactively.
- Carsten
On Jun 17, 2009, at 1:15 PM, Andreas Seltenreich wrote:
>> Your bug report will be posted to the emacs-pretest-bug@gnu.org
>> mailing list.
>
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>
> org-store-link works fine when recording a keyboard macro but it is a
> NOP when executing it. The following change appears to fix it.
>
> regards,
> andreas
>
>> In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu)
>> of 2009-05-28 on tengen
>
> --8<---------------cut here---------------start------------->8---
> *** org.el.~1.48.~ 2009-02-20 10:02:49.000000000 +0100
> --- org.el 2009-06-17 12:55:15.000000000 +0200
> ***************
> *** 6594,6600 ****
> desc (or desc cpltxt))
> (if (equal desc "NONE") (setq desc nil))
>
> ! (if (and (interactive-p) link)
> (progn
> (setq org-stored-links
> (cons (list link desc) org-stored-links))
> --- 6594,6600 ----
> desc (or desc cpltxt))
> (if (equal desc "NONE") (setq desc nil))
>
> ! (if (and (or (interactive-p) executing-kbd-macro) link)
> (progn
> (setq org-stored-links
> (cons (list link desc) org-stored-links))
> --8<---------------cut here---------------end--------------->8---
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-06-24 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:15 23.0.94; [PATCH] org-store-link broken within kbd macros Andreas Seltenreich
2009-06-24 12:17 ` Carsten Dominik [this message]
2009-06-24 12:39 ` Andreas Seltenreich
2009-06-24 12:44 ` Carsten Dominik
2009-06-27 0:43 ` bug#3597: [Orgmode] " Stefan Monnier
2009-06-27 9:38 ` bug#3597: " Carsten Dominik
2009-07-02 3:39 ` Samuel Wales
2009-07-02 5:52 ` Bastien
2009-07-02 6:05 ` Samuel Wales
2009-07-02 7:08 ` Bastien
2009-07-02 18:02 ` Samuel Wales
2009-07-03 9:18 ` Bastien
2009-07-26 0:44 ` Samuel Wales
2011-03-03 21:15 ` bug#3597: " Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=emacs-pretest-bug@gnu.org \
--cc=seltenreich@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).