From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros Date: Wed, 24 Jun 2009 14:44:23 +0200 Message-ID: References: <87bponi011.fsf@gate450.dyndns.org> <8317C86B-9281-4E9E-97C2-E0EDF6C0144B@gmail.com> <878wjhbyc1.fsf@gate450.dyndns.org> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJRq5-0004vP-5Q for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:44:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJRq0-0004sf-Bs for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:44:32 -0400 Received: from [199.232.76.173] (port=45123 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJRq0-0004sX-3O for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:44:28 -0400 Received: from mail-ew0-f220.google.com ([209.85.219.220]:35048) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJRpy-0003WD-NX for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 08:44:26 -0400 Received: by ewy20 with SMTP id 20so1192905ewy.42 for ; Wed, 24 Jun 2009 05:44:26 -0700 (PDT) In-Reply-To: <878wjhbyc1.fsf@gate450.dyndns.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Andreas Seltenreich Cc: emacs-orgmode@gnu.org, 3597@emacsbugs.donarmstrong.com On Jun 24, 2009, at 2:39 PM, Andreas Seltenreich wrote: > > [Sorry about setting Cc instead X-Debbugs-Cc and causing the duplicate > report. I set a proper Mail-Followup-To header now.] > > Carsten Dominik writes: > >> This looks to me as if it was a bug in keyboard macro execution, >> which should call functions interactively. > > The docstring for interactive-p has the following paragraph: > > ,----[ C-h f interactive-p RET ] > | The only known proper use of `interactive-p' is in deciding > whether to > | display a helpful message, or how to display it. If you're thinking > | of using it for any other purpose, it is quite likely that you're > | making a mistake. Think: what do you want to do when the command is > | called from a keyboard macro? > `---- > > The elisp reference states: > > ,----[ (info "(elisp)Distinguish Interactive") ] > | -- Function: interactive-p > | This function returns `t' if the containing function (the one > | whose code includes the call to `interactive-p') was called in > | direct response to user input. This means that it was called > with > | the function `call-interactively', and that a keyboard macro is > | not running, and that Emacs is not running in batch mode. > `---- > > This sounds like interactive-p is working as documented and the > excplicit check I proposed would be neccessary. True enough, and I am applying your fix. Thanks. - Carsten > > Thanks, > andreas