[BUG] org-indent breaks indentation of inline tasks (was: full production use of org-mode: time to say thanks again!)

* [BUG] org-indent breaks indentation of inline tasks (was: full production use of org-mode: time to say thanks again!)
@ 2010-11-02 13:01 Jeff Horn
  0 siblings, 0 replies; only message in thread
From: Jeff Horn @ 2010-11-02 13:01 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: org-mode mailing list, Eric S Fraga, Nicolas Goaziou

Were these patches merged into the most recent update? Indentation
after inline tasks is broken for me.

1) use org-inlinetask-insert-task to start a new task
2) go to the "end" line, press return
3) observe indentation at column below "E" in "END" from line above
4) turn off org-indent mode and note indentation is correct

I was expecting indentation to be correct with indent-mode turned on.

Thanks,
Jeff

On Mon, Oct 11, 2010 at 4:04 AM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> Hi,
>
> On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote:
>
>> Hello,
>>
>> Could you try the following patch and tell me if it fixes your issue?
>
> A quick test shows that things seem to work well in inlinetasks which are
> properly ended with an END line.
>
> There is also a dirty form of inline tasks which allows
> only a planning line (SCHEDULED etc) and one or several
> drawers directly after the task line, and then no
> END line is necessary.  But I guess it is fair
> to force the END line if you do want to have
> proper indentation.
>
> Eric Fraga, have you tested the patch yet?  Please do
> so when you wake up from your two-week sleep, so that
> we can check this in.
>
> Thanks Nicolas!
>
> I am seeing now two things that should be added:
>
>  - M-RET after inline tasks should ignore the inline task
>    and make a new entry with normal indentation
>  - Maybe I should treat inline tasks with proper END
>    statement as a drawer and fold it?  Comments?
>
>
>>
>> As a side note (to maintainers), the second patch isn't really needed,
>> but I thought, while I was at it, that it would make sense
>> (`org-inlinetask-min-level' doesn't need to be a boolean).
>
> Hmmm, what happens is a user has customized this variable and it has a value
> nil.  I guess then your patch will break things?
>
> So I think we need to keep testing the value in the code, but it is OK to
> change the customize type.
>
>>
>> Regards,
>>
>> -- Nicolas
>>
>>
>> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002-inlinetask-Make-org-inlinetask-min-level-an-integer-.patch>
>
> - Carsten
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

-- 
Jeffrey Horn
Graduate Lecturer and PhD Student in Economics
George Mason University

(704) 271-4797
jhorn@gmu.edu
jrhorn424@gmail.com

http://www.failuretorefrain.com/jeff/

^ permalink raw reply	[flat|nested] only message in thread