From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Horn Subject: [BUG] org-indent breaks indentation of inline tasks (was: full production use of org-mode: time to say thanks again!) Date: Tue, 2 Nov 2010 09:01:37 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=33547 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDGtF-0003TS-V7 for emacs-orgmode@gnu.org; Tue, 02 Nov 2010 09:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PDGV1-0004Lz-9r for emacs-orgmode@gnu.org; Tue, 02 Nov 2010 09:02:05 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:55116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PDGV1-0004Ld-1l for emacs-orgmode@gnu.org; Tue, 02 Nov 2010 09:02:03 -0400 Received: by fxm2 with SMTP id 2so6104337fxm.0 for ; Tue, 02 Nov 2010 06:02:01 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: org-mode mailing list , Eric S Fraga , Nicolas Goaziou Were these patches merged into the most recent update? Indentation after inline tasks is broken for me. 1) use org-inlinetask-insert-task to start a new task 2) go to the "end" line, press return 3) observe indentation at column below "E" in "END" from line above 4) turn off org-indent mode and note indentation is correct I was expecting indentation to be correct with indent-mode turned on. Thanks, Jeff On Mon, Oct 11, 2010 at 4:04 AM, Carsten Dominik wrote: > Hi, > > On Oct 11, 2010, at 8:34 AM, Nicolas Goaziou wrote: > >> Hello, >> >> Could you try the following patch and tell me if it fixes your issue? > > A quick test shows that things seem to work well in inlinetasks which are > properly ended with an END line. > > There is also a dirty form of inline tasks which allows > only a planning line (SCHEDULED etc) and one or several > drawers directly after the task line, and then no > END line is necessary. =A0But I guess it is fair > to force the END line if you do want to have > proper indentation. > > Eric Fraga, have you tested the patch yet? =A0Please do > so when you wake up from your two-week sleep, so that > we can check this in. > > Thanks Nicolas! > > I am seeing now two things that should be added: > > =A0- M-RET after inline tasks should ignore the inline task > =A0 =A0and make a new entry with normal indentation > =A0- Maybe I should treat inline tasks with proper END > =A0 =A0statement as a drawer and fold it? =A0Comments? > > >> >> As a side note (to maintainers), the second patch isn't really needed, >> but I thought, while I was at it, that it would make sense >> (`org-inlinetask-min-level' doesn't need to be a boolean). > > Hmmm, what happens is a user has customized this variable and it has a va= lue > nil. =A0I guess then your patch will break things? > > So I think we need to keep testing the value in the code, but it is OK to > change the customize type. > >> >> Regards, >> >> -- Nicolas >> >> >> <0001-Fix-indentation-of-text-after-an-inline-task.patch><0002-inlinetas= k-Make-org-inlinetask-min-level-an-integer-.patch> > > - Carsten > > > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > --=20 Jeffrey Horn Graduate Lecturer and PhD Student in Economics George Mason University (704) 271-4797 jhorn@gmu.edu jrhorn424@gmail.com http://www.failuretorefrain.com/jeff/