From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, ox] #+INCLUDE resolves links
Date: Wed, 01 Oct 2014 22:03:39 +0200 [thread overview]
Message-ID: <87y4sz7e1w.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871tqskce9.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 30 Sep 2014 23:48:46 +0200")
Hello,
Rasmus <rasmus@gmx.us> writes:
> Changes are one sentence in the documentations, casing, and I changed
> the regexp so that :only-contents is valid (it's nil).
Thank you.
It isn't very important, but you forgot full stops at the end of
comments in the test file.
> Is it better now?
I think so.
> I want to discuss one more important potential issue before having the
> patch applied. Currently, location is ignored if the included part is
> not an env (line 3381) and not a block (3392). I'm not sure this is
> right. I could do one of the following:
>
> 1. Nothing (current state)
> 2. Throw an error if location and env or block are combined.
> 3. Try to use location even if block is set. Recall, though, that
> location is resolved using org-mode.
> 4. Let location be a general regexp if env or block is non-nil.
> But then we are breaking with the org file-link idea.
> 5. Make location work for org files when env or block, otherwise
> throw an error.
>
> WDYT?
I think option 1 is perfect. If a block with org contents is needed, one
can always do
#+begin_center
#+include: "file.org::*headline"
#+end_center
Block and environments are really meant for literal insertion, where
locations do not apply.
> Less important. Should the <I "speedkey" (I don't know if that's the
> right term) prompt for a location, or change the cursor position to
> after the filename?
The "right term" is structure template. Since those are configurable,
I think the default, simple, behaviour is preferable.
> + (only-contents
> + (and (string-match ":only-contents *?\\([^: \r\t\n]\\S-*\\)?" value)
Is the shy *? necessary?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-10-01 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 0:51 [patch, ox] #+INCLUDE resolves links Rasmus
2014-09-21 11:46 ` Rasmus
2014-09-21 13:53 ` Nicolas Goaziou
2014-09-21 14:46 ` Rasmus
2014-09-21 19:51 ` Nicolas Goaziou
2014-09-23 23:25 ` Rasmus
2014-09-24 21:22 ` Nicolas Goaziou
2014-09-28 19:32 ` Rasmus
2014-09-30 8:07 ` Nicolas Goaziou
2014-09-30 10:18 ` Rasmus
2014-09-30 14:29 ` Nicolas Goaziou
2014-09-30 21:48 ` Rasmus
2014-10-01 20:03 ` Nicolas Goaziou [this message]
2014-10-01 21:27 ` Rasmus
2014-10-02 7:29 ` Xavier Garrido
2014-10-02 8:55 ` Rasmus
2014-10-02 16:30 ` Aaron Ecay
2014-10-02 16:53 ` Nicolas Goaziou
2014-10-02 17:47 ` Rasmus
2014-10-02 19:11 ` Achim Gratz
2014-10-02 20:58 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4sz7e1w.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).