emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Xavier Garrido <xavier.garrido@gmail.com>
To: Rasmus <rasmus@gmx.us>, mail@nicolasgoaziou.fr
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch, ox] #+INCLUDE resolves links
Date: Thu, 02 Oct 2014 09:29:17 +0200	[thread overview]
Message-ID: <542CFECD.5000609@gmail.com> (raw)
In-Reply-To: <87lhoz7a5k.fsf@gmx.us>

Hi,

Following the discussion here 
http://article.gmane.org/gmane.emacs.orgmode/91322/match=improved+way, I 
have quickly tested the patch and it perfectly fits my needs. So thanks 
again.

Just one remark : there is an undefined @ref tag in org.texi (line 
10011) file that should referred to "search option in file link". 
Compilation fails due to error in documentation generation.

Cheers,
Xavier

Le 01/10/2014 23:27, Rasmus a écrit :
> Hi,
>
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> It isn't very important, but you forgot full stops at the end of
>> comments in the test file.
>
> Fixed.
>
>>> I want to discuss one more important potential issue before having the
>>> patch applied.  Currently, location is ignored if the included part is
>>> not an env (line 3381) and not a block (3392).  I'm not sure this is
>>> right.  I could do one of the following:
>>>
>>>     1. Nothing (current state)
>>>     2. Throw an error if location and env or block are combined.
>>>     3. Try to use location even if block is set.  Recall, though, that
>>>        location is resolved using org-mode.
>>>     4. Let location be a general regexp if env or block is non-nil.
>>>        But then we are breaking with the org file-link idea.
>>>     5. Make location work for org files when env or block, otherwise
>>>        throw an error.
>>>
>>> WDYT?
>>
>> I think option 1 is perfect. If a block with org contents is needed, one
>> can always do
>>
>>    #+begin_center
>>    #+include: "file.org::*headline"
>>    #+end_center
>>
>> Block and environments are really meant for literal insertion, where
>> locations do not apply.
>
> Great!  Less work.
>
> We can always tune it later as necessary.
>
>>> +		 (only-contents
>>> + (and (string-match ":only-contents *?\\([^: \r\t\n]\\S-*\\)?"
>>> value)
>>
>> Is the shy *? necessary?
>
> No!  Only the * is necessary to catch an implicit nil.  Thanks.
>
> Feel free to commit the attached patch if there's nothing else.
>
> —Rasmus
>

next prev parent reply	other threads:[~2014-10-02  7:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21  0:51 [patch, ox] #+INCLUDE resolves links Rasmus
2014-09-21 11:46 ` Rasmus
2014-09-21 13:53   ` Nicolas Goaziou
2014-09-21 14:46     ` Rasmus
2014-09-21 19:51       ` Nicolas Goaziou
2014-09-23 23:25     ` Rasmus
2014-09-24 21:22       ` Nicolas Goaziou
2014-09-28 19:32         ` Rasmus
2014-09-30  8:07           ` Nicolas Goaziou
2014-09-30 10:18             ` Rasmus
2014-09-30 14:29               ` Nicolas Goaziou
2014-09-30 21:48                 ` Rasmus
2014-10-01 20:03                   ` Nicolas Goaziou
2014-10-01 21:27                     ` Rasmus
2014-10-02  7:29                       ` Xavier Garrido [this message]
2014-10-02  8:55                         ` Rasmus
2014-10-02 16:30                           ` Aaron Ecay
2014-10-02 16:53                           ` Nicolas Goaziou
2014-10-02 17:47                             ` Rasmus
2014-10-02 19:11                               ` Achim Gratz
2014-10-02 20:58                                 ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542CFECD.5000609@gmail.com \
    --to=xavier.garrido@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).