From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [patch, ox] #+INCLUDE resolves links
Date: Tue, 30 Sep 2014 12:18:22 +0200 [thread overview]
Message-ID: <87mw9hcsy9.fsf@gmx.us> (raw)
In-Reply-To: 87tx3po7kj.fsf@nicolasgoaziou.fr
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> Just out of curiosity, what is an example of a element that can be
>> named and does not have a :contents-begin?
>
> #+name: empty-drawer
> :DRAWER:
> :END:
Thanks.
>> Okay, there's a lot of improvements in that suggestion. However, it
>> misses this case which created using only "official" shortcuts
>>
>> * head
>> SCHEDULED: <2014-09-28 sun>
>> :LOGBOOK:
>> - Note taken on [2014-09-28 sat 12:21] \\
>> a drawer
>> :END:
>> :PROPERTIES:
>> :CUSTOM_ID: h
>> :END:
>
> This was done on purpose, anticipating a patch I'm working on. Anyway,
> it doesn't matter much. I'll revert it once my work is ready.
Okay. If you discussed on the list I missed it.
>> +elements.}. If the @code{:only-contents} property is non-nil, only the
>> +contents of the requested element will be included, omitting any
>> +property-drawers, planning-lines, attributes, captions etc. The
>
> properties (or property) drawer, planning line.
>
> Do you think it's worth specifying that captions and attributes will be
> ignored? It seems pretty obvious to me as they do not belong to contents
> (unlike to planning and properties drawers).
It's two extra words and maybe it's helpful to make the concept clear
to people unfamilar with org-element. The statement "contents of the
requested element", while technically clear, is only barely
comprehensible for the uninvited.
However, it's only tweo extra words, so I'm happy to remove them if
you have strong feeling about this.
>> + (only-contents
>> + (and (string-match ":only-contents +\\([^: \r\t\n]\\S-*\\)" value)
>> + (prog1 (org-not-nil (match-string 1 value))
>> + (setq value (replace-match "" nil nil value)))))
>
> Why do you need to remove match from VALUE? AFAICT, the only match that
> needs to be removed is the file name. Others are regular.
I don't know what you mean with regular. Anyway, my reasoning is that
this INCLUDE-command
#+INCLUDE: "/tmp/test0.org" :my-random-prop "foo"
Will give me something like:
\#+\textsc{begin}\(_{\text{my}}\)-random-prop
\section{test0}
\label{sec-2}
1
\#+\textsc{end}\(_{\text{my}}\)-random-prop
In casual testing similar stuff happened when I did not remove the
match. It could have been it was a bit too casual and that I
misspelling the property. I will test this properly later.
> Mind the 80th column in your tests, and full stop at end of comments.
OK, I'll fix it.
> Besides the minor issues above, it looks good. Feel free to push it
> whenever you want.
Don't have push.
—Rasmus
--
Lasciate ogni speranza o voi che entrate: siete nella mani di'machellaio
next prev parent reply other threads:[~2014-09-30 10:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 0:51 [patch, ox] #+INCLUDE resolves links Rasmus
2014-09-21 11:46 ` Rasmus
2014-09-21 13:53 ` Nicolas Goaziou
2014-09-21 14:46 ` Rasmus
2014-09-21 19:51 ` Nicolas Goaziou
2014-09-23 23:25 ` Rasmus
2014-09-24 21:22 ` Nicolas Goaziou
2014-09-28 19:32 ` Rasmus
2014-09-30 8:07 ` Nicolas Goaziou
2014-09-30 10:18 ` Rasmus [this message]
2014-09-30 14:29 ` Nicolas Goaziou
2014-09-30 21:48 ` Rasmus
2014-10-01 20:03 ` Nicolas Goaziou
2014-10-01 21:27 ` Rasmus
2014-10-02 7:29 ` Xavier Garrido
2014-10-02 8:55 ` Rasmus
2014-10-02 16:30 ` Aaron Ecay
2014-10-02 16:53 ` Nicolas Goaziou
2014-10-02 17:47 ` Rasmus
2014-10-02 19:11 ` Achim Gratz
2014-10-02 20:58 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw9hcsy9.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).