emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Bastien <bzg@gnu.org>, bruce robertson <brucer42@gmail.com>,
Subject: bug#52341: Fwd: 29.0.50; org-priority 'SPC to remove' doesn't work
Date: Tue, 07 Dec 2021 20:58:52 -0500	[thread overview]
Message-ID: <87y24v7t7n.fsf@kyleam.com> (raw)
In-Reply-To: <874k7khf2k.fsf@gmail.com>

Robert Pluim writes:

>>>>>> On Mon, 06 Dec 2021 20:48:46 -0500, Kyle Meyer <kyle@kyleam.com> said:
>     Kyle> Right, this stems from org-priority feeding " " to string-to-number and
>     Kyle> ending up with 0 instead of the ?\s (32) that's used downstream to
>     Kyle> signal "remove".  The problem goes back to when support for numeric
>     Kyle> priorities was added in Org v9.4's 4f98694bf (Allow numeric values for
>     Kyle> priorities, 2020-01-30).
>     Kyle> I suppose one solution would be to check for " " and translate that to
>     Kyle> the ?\s so that the remove is triggered.  I'll plan to apply the change
>     Kyle> below to Org's bugfix branch in a day or two unless the author of the
>     Kyle> above commit (+cc) or someone else has another suggestion.
> That fixes part of the issue, but still when using numeric priorities,
> removal will be 'SPC RET' rather than 'SPC'.

If someone 1) uses numeric priorities and 2) has org-priority-lowest
above 9, read-string is used to prompt with "Priority M-N, SPC to
remove: ".  They need to use 'SPC RET' just as they need to use, say, '3
RET'.  That is, it's consistent with the prompt behavior for entering
the actual priorities.

Perhaps that should change in some way (though I'm not planning on
working on it myself), but in my view that behavior shouldn't be
conflated with SPC not being translated to "remove the priority".

  reply	other threads:[~2021-12-08  2:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CACdyrTmdEOp1zb6bMVQBuyrLsGiRhpzdWXdzBVbxiddaKqcFrA@mail.gmail.com>
     [not found] ` <CACdyrTmDB5hB3DzBm_Xu2mzUU4iaV-3jd=rHb6p3b3NhfxBpvw@mail.gmail.com>
2021-12-07  1:48   ` bug#52341: Fwd: 29.0.50; org-priority 'SPC to remove' doesn't work Kyle Meyer
2021-12-07 10:41     ` Robert Pluim
2021-12-08  1:58       ` Kyle Meyer [this message]
2021-12-10  3:48     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y24v7t7n.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=52341@debbugs.gnu.org \
    --cc=brucer42@gmail.com \
    --cc=bzg@gnu.org \
    --cc=rpluim@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).