From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4IvsHxISsGF7SgAAgWs5BA (envelope-from ) for ; Wed, 08 Dec 2021 03:01:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0MKhGxISsGHKEAAAbx9fmQ (envelope-from ) for ; Wed, 08 Dec 2021 02:01:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7737ED130 for ; Wed, 8 Dec 2021 03:01:53 +0100 (CET) Received: from localhost ([::1]:45506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mumHI-0005Zi-4N for larch@yhetil.org; Tue, 07 Dec 2021 21:01:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mumFX-0005YB-38 for emacs-orgmode@gnu.org; Tue, 07 Dec 2021 21:00:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mumFW-0003PH-RZ for emacs-orgmode@gnu.org; Tue, 07 Dec 2021 21:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mumFW-0000fB-I9 for emacs-orgmode@gnu.org; Tue, 07 Dec 2021 21:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52341: Fwd: 29.0.50; org-priority 'SPC to remove' doesn't work Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org Resent-Date: Wed, 08 Dec 2021 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52341 X-GNU-PR-Package: org-mode X-GNU-PR-Keywords: To: Robert Pluim Received: via spool by 52341-submit@debbugs.gnu.org id=B52341.16389287432456 (code B ref 52341); Wed, 08 Dec 2021 02:00:02 +0000 Received: (at 52341) by debbugs.gnu.org; 8 Dec 2021 01:59:03 +0000 Received: from localhost ([127.0.0.1]:39221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mumEZ-0000dY-0Q for submit@debbugs.gnu.org; Tue, 07 Dec 2021 20:59:03 -0500 Received: from out1.migadu.com ([91.121.223.63]:46033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mumES-0000d3-TE for 52341@debbugs.gnu.org; Tue, 07 Dec 2021 20:59:01 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1638928734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bp9fMXINCWmKgchKAFZUKzrYXoq3cbNRiXF0tYpfSqc=; b=mL4FKd5N6zu3wKy3N58WJ54wzBM30rU85vQQ5qA6pV8PHCohgpD8Ts4oKYLwklpB4eyQD4 s6evmC/SAczqzYyqebixUF/FMnCv/3YFrEsDBSjLEo0j3GSBv6CUoqMMnoA/Zf+6e+r0w5 BWIDZkRcyCA5GEMOORVd9S7+SzAVNbdjW4kdlkLmzQ3jvWiT09b42No+7gEbdOrMNPLnE2 NXiBUU9duRWcYyvgIgvEGSlbqvfW5wPGvzY+581cImLY9besJTG5Y0ccDUlYrZg6npf3hD lzD9VgqvwMU80EokIjyk/NlUEKurxaaR28Xb4B/mW7HOKqB/kZ2jaI33lQ9upA== From: Kyle Meyer In-Reply-To: <874k7khf2k.fsf@gmail.com> References: <877dch89s1.fsf@kyleam.com> <874k7khf2k.fsf@gmail.com> Date: Tue, 07 Dec 2021 20:58:52 -0500 Message-ID: <87y24v7t7n.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: emacs-orgmode@gnu.org List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , bruce robertson , 52341@debbugs.gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638928914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Bp9fMXINCWmKgchKAFZUKzrYXoq3cbNRiXF0tYpfSqc=; b=hgxXiEXKaGUA95BkZMljbVmWDOiv3ZRXHb5F77Fm94EHBf9dBl0MXaWHNhxA4JZ2Ci2SBZ UbnfXl3S2YmzJBoQi058qyR8itLiyNOkM7jEWpYlUzKVOmnQ8X5reHX5yqmm8BEor+gy9E XkOjKX32fYeYUg+mV4xG5NkJ+OPs+HXySOUdzNcG3nkfBJ/UhQ7RHCLFMJVWnHnkloo6X6 J/SNmiKqIdHIS1fazdEMt4Xxu1CMAgrRCjKPFDmAFRfyV6Zh/NkbWUQXT7BZNIJuIKhPgc 8YY4Ukq/OjNHoiXy/TypMSd52x6mUTfZ0wyZrZFxmR5w6HaK8CSiYs6H06U2xg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638928914; a=rsa-sha256; cv=none; b=hZ/rN3RKoD7KiEYZuSBCZIDK2qWo4NHRn4cLc7ZafgLXpJI/rG1jVXU7BmYWS0V1xYN3zV EJCtmfcvKeNjBZ/bJNCUvpiY2tRTj7vALGPqvQUoq0iOBMPT5qWiAqQFjbiwrOuQGJN+rd 1qUQ0fqIywF6gsEM0Cy8mhClf9hCo2QZuk54DNNC8A1MBz6cmwtUwJPg8RED8RAIy4LG0z NQTAsgMP+cDnJlR/rKVaAADJrMh30EAHWkEooLh47lu2uApXWx44ebpwAkHm+ylHZxe/oL zsS0S8vRglEKNKU79r4dazgisHnVpv5OMT8frq8uk4Y9gIsjLKNmMGN7+ZT6Cw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=mL4FKd5N; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=mL4FKd5N; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7737ED130 X-Spam-Score: -3.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: U2SH0skqVvOV Robert Pluim writes: >>>>>> On Mon, 06 Dec 2021 20:48:46 -0500, Kyle Meyer said: > Kyle> Right, this stems from org-priority feeding " " to string-to-number and > Kyle> ending up with 0 instead of the ?\s (32) that's used downstream to > Kyle> signal "remove". The problem goes back to when support for numeric > Kyle> priorities was added in Org v9.4's 4f98694bf (Allow numeric values for > Kyle> priorities, 2020-01-30). > > Kyle> I suppose one solution would be to check for " " and translate that to > Kyle> the ?\s so that the remove is triggered. I'll plan to apply the change > Kyle> below to Org's bugfix branch in a day or two unless the author of the > Kyle> above commit (+cc) or someone else has another suggestion. > > That fixes part of the issue, but still when using numeric priorities, > removal will be 'SPC RET' rather than 'SPC'. If someone 1) uses numeric priorities and 2) has org-priority-lowest above 9, read-string is used to prompt with "Priority M-N, SPC to remove: ". They need to use 'SPC RET' just as they need to use, say, '3 RET'. That is, it's consistent with the prompt behavior for entering the actual priorities. Perhaps that should change in some way (though I'm not planning on working on it myself), but in my view that behavior shouldn't be conflated with SPC not being translated to "remove the priority".