From: Kyle Meyer <kyle@kyleam.com>
To: bruce robertson <brucer42@gmail.com>
Cc: Bastien <bzg@gnu.org>, 52341@debbugs.gnu.org
Subject: bug#52341: Fwd: 29.0.50; org-priority 'SPC to remove' doesn't work
Date: Mon, 06 Dec 2021 20:48:46 -0500 [thread overview]
Message-ID: <877dch89s1.fsf@kyleam.com> (raw)
In-Reply-To: <CACdyrTmDB5hB3DzBm_Xu2mzUU4iaV-3jd=rHb6p3b3NhfxBpvw@mail.gmail.com>
bruce robertson writes:
> 1. in init.el:
> (custom-set-variables
> '(org-priority-default 32)
> '(org-priority-highest 0)
> '(org-priority-lowest 31)
> )
> 2. position to line in .org file:
> ** TODO [#0] test line
>
> 3. from M-x view-lossage:
> C-c , ;; org-priority
>
> 4. mini-buffer displays:
> "Priority 0-31, SPC to remove: "
>
> 5. further in view-lossage:
> SPC ;; self-insert-command
> <return> ;; exit-minibuffer
>
> 4. from *Messages* (and mini-buffer):
> Priority of current item set to 0
>
> 5. PROBLEM:
> I wanted to remove priority.
>
> 6. WORK-AROUND:
> set priority to 32. Then priority disappears. Perhaps this is because 32
> is space code or because I've set org-priority-default to 32.
> ( I spent a medium amount of time to find this behavior. )
>
> 7. SUGGESTION:
> rewrite org-priority to have a clear distinction between numbers and
> characters and whatever will be used to remove the priority.
> ( I gave a look at this but my emacs-fu is too weak. Or my time-fu is
> too small. )
Right, this stems from org-priority feeding " " to string-to-number and
ending up with 0 instead of the ?\s (32) that's used downstream to
signal "remove". The problem goes back to when support for numeric
priorities was added in Org v9.4's 4f98694bf (Allow numeric values for
priorities, 2020-01-30).
I suppose one solution would be to check for " " and translate that to
the ?\s so that the remove is triggered. I'll plan to apply the change
below to Org's bugfix branch in a day or two unless the author of the
above commit (+cc) or someone else has another suggestion.
diff --git a/lisp/org.el b/lisp/org.el
index 1a1375461..998da0656 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11323,13 +11323,14 @@ (defun org-priority (&optional action show)
(setq
new
(if nump
- (let ((msg (format "Priority %s-%s, SPC to remove: "
- (number-to-string org-priority-highest)
- (number-to-string org-priority-lowest))))
- (if (< 9 org-priority-lowest)
- (string-to-number (read-string msg))
- (message msg)
- (string-to-number (char-to-string (read-char-exclusive)))))
+ (let* ((msg (format "Priority %s-%s, SPC to remove: "
+ (number-to-string org-priority-highest)
+ (number-to-string org-priority-lowest)))
+ (s (if (< 9 org-priority-lowest)
+ (read-string msg)
+ (message msg)
+ (char-to-string (read-char-exclusive)))))
+ (if (equal s " ") ?\s (string-to-number s)))
(progn (message "Priority %c-%c, SPC to remove: "
org-priority-highest org-priority-lowest)
(save-match-data
next parent reply other threads:[~2021-12-07 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACdyrTmdEOp1zb6bMVQBuyrLsGiRhpzdWXdzBVbxiddaKqcFrA@mail.gmail.com>
[not found] ` <CACdyrTmDB5hB3DzBm_Xu2mzUU4iaV-3jd=rHb6p3b3NhfxBpvw@mail.gmail.com>
2021-12-07 1:48 ` Kyle Meyer [this message]
2021-12-07 10:41 ` bug#52341: Fwd: 29.0.50; org-priority 'SPC to remove' doesn't work Robert Pluim
2021-12-08 1:58 ` Kyle Meyer
2021-12-10 3:48 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dch89s1.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=52341@debbugs.gnu.org \
--cc=brucer42@gmail.com \
--cc=bzg@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).