emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-src.el: Add plain to org-src-window-setup customization
@ 2022-07-08 17:40 Matt Rudary
  2022-07-09  4:07 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Rudary @ 2022-07-08 17:40 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]

Hi,

I was trying to customize org-src-window-setup and noticed that "plain" was
not an option, despite being documented. I checked the commit and it seems
the implementation was added but the choice list in the defcustom was not
updated.

Best,
Matt Rudary

[-- Attachment #1.2: Type: text/html, Size: 348 bytes --]

[-- Attachment #2: 0001-org-src.el-Add-plain-to-org-src-window-setup-customi.patch --]
[-- Type: application/octet-stream, Size: 1067 bytes --]

From 67c66cb70b63fc978cc65d6b871ba3e6c9485c8d Mon Sep 17 00:00:00 2001
From: Matt Rudary <matt@rudary.com>
Date: Fri, 8 Jul 2022 11:56:55 -0400
Subject: [PATCH] org-src.el: Add plain to org-src-window-setup customization

* lisp/org-src.el (org-src-window-setup): Add plain to the list of
valid choices for org-src-window-setup.

A previous change added it to the documentation and to the pcase that
process this variable in org-src-switch-to-buffer, but the defcustom
did not include it as a valid option.

TINYCHANGE
---
 lisp/org-src.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-src.el b/lisp/org-src.el
index 26cd533f1..59d8ee305 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -171,6 +171,7 @@ Values that modify the window layout (reorganize-frame, split-window-below,
 split-window-right) will restore the layout after exiting the edit buffer."
   :group 'org-edit-structure
   :type '(choice
+          (const plain)
 	  (const current-window)
 	  (const split-window-below)
 	  (const split-window-right)
-- 
2.32.1 (Apple Git-133)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-src.el: Add plain to org-src-window-setup customization
  2022-07-08 17:40 [PATCH] org-src.el: Add plain to org-src-window-setup customization Matt Rudary
@ 2022-07-09  4:07 ` Ihor Radchenko
  2022-07-11  8:41   ` Bastien Guerry
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2022-07-09  4:07 UTC (permalink / raw)
  To: Matt Rudary, Bastien; +Cc: emacs-orgmode

Matt Rudary <matt@rudary.com> writes:

> I was trying to customize org-src-window-setup and noticed that "plain" was
> not an option, despite being documented. I checked the commit and it seems
> the implementation was added but the choice list in the defcustom was not
> updated.

Thanks for your contribution!
Applied onto main via a7cc95c60 with minor amendments to the commit
message. I have added `' quotes to function symbols.

Bastien, could you please add Matt to tiny change contributor list?

Best,
Ihor


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-src.el: Add plain to org-src-window-setup customization
  2022-07-09  4:07 ` Ihor Radchenko
@ 2022-07-11  8:41   ` Bastien Guerry
  0 siblings, 0 replies; 3+ messages in thread
From: Bastien Guerry @ 2022-07-11  8:41 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Matt Rudary, emacs-orgmode

Hi Ihor,

Ihor Radchenko <yantar92@gmail.com> writes:

> Bastien, could you please add Matt to tiny change contributor list?

Done in https://git.sr.ht/~bzg/worg/commit/f7825a7c, also sorting the
list of names.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-11  8:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-08 17:40 [PATCH] org-src.el: Add plain to org-src-window-setup customization Matt Rudary
2022-07-09  4:07 ` Ihor Radchenko
2022-07-11  8:41   ` Bastien Guerry

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).