emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Rudary <matt@rudary.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-src.el: Add plain to org-src-window-setup customization
Date: Fri, 8 Jul 2022 13:40:12 -0400	[thread overview]
Message-ID: <CAA+UOSr-cZpqy2YCDKsxcvtiFQao74AbHkiDMkELMznBUwijNA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]

Hi,

I was trying to customize org-src-window-setup and noticed that "plain" was
not an option, despite being documented. I checked the commit and it seems
the implementation was added but the choice list in the defcustom was not
updated.

Best,
Matt Rudary

[-- Attachment #1.2: Type: text/html, Size: 348 bytes --]

[-- Attachment #2: 0001-org-src.el-Add-plain-to-org-src-window-setup-customi.patch --]
[-- Type: application/octet-stream, Size: 1067 bytes --]

From 67c66cb70b63fc978cc65d6b871ba3e6c9485c8d Mon Sep 17 00:00:00 2001
From: Matt Rudary <matt@rudary.com>
Date: Fri, 8 Jul 2022 11:56:55 -0400
Subject: [PATCH] org-src.el: Add plain to org-src-window-setup customization

* lisp/org-src.el (org-src-window-setup): Add plain to the list of
valid choices for org-src-window-setup.

A previous change added it to the documentation and to the pcase that
process this variable in org-src-switch-to-buffer, but the defcustom
did not include it as a valid option.

TINYCHANGE
---
 lisp/org-src.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-src.el b/lisp/org-src.el
index 26cd533f1..59d8ee305 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -171,6 +171,7 @@ Values that modify the window layout (reorganize-frame, split-window-below,
 split-window-right) will restore the layout after exiting the edit buffer."
   :group 'org-edit-structure
   :type '(choice
+          (const plain)
 	  (const current-window)
 	  (const split-window-below)
 	  (const split-window-right)
-- 
2.32.1 (Apple Git-133)


             reply	other threads:[~2022-07-08 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 17:40 Matt Rudary [this message]
2022-07-09  4:07 ` [PATCH] org-src.el: Add plain to org-src-window-setup customization Ihor Radchenko
2022-07-11  8:41   ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA+UOSr-cZpqy2YCDKsxcvtiFQao74AbHkiDMkELMznBUwijNA@mail.gmail.com \
    --to=matt@rudary.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).