emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [Patch] [Objective]Caml dialect in listings
@ 2021-01-14 13:24 Basile Pesin
  2021-01-25  4:10 ` Kyle Meyer
  0 siblings, 1 reply; 2+ messages in thread
From: Basile Pesin @ 2021-01-14 13:24 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi,

I have just started using `org-mode`, and it is very cool ! Thank you 
for your collective work.

There is a small patch I would like to submit : when writing listings 
for the OCaml programming language, one should use the "[Objective]Caml" 
dialect, which is different from the "Caml" dialect. This is not 
reflected in the latex exported code.

The attached patch changes this. Thank you in advance for your patience, 
this is my first patch so I hope I did everything correctly.

Cheers !

-- 
Basile Pesin
Inria Paris - PARKAS


[-- Attachment #2: 0001-ox-latex.el-Use-Objective-Caml-dialect.patch --]
[-- Type: text/x-patch, Size: 1016 bytes --]

From 7343ff30927876966d3eabd3c1ee9c2afa018d2e Mon Sep 17 00:00:00 2001
From: Basile Pesin <basile.pesin@gmail.com>
Date: Thu, 14 Jan 2021 13:16:54 +0100
Subject: [PATCH] ox-latex.el : Use [Objective]Caml dialect

* ox-latex.el (org-latex-listings-langs): Change the binding for
  `ocaml' to "[Objective]Caml"

The "[Objective]Caml" dialect syntax highlighting is different from the
"Caml" one (reflecting the added features of OCaml compared to
Caml-light).
TINYCHANGE
---
 lisp/ox-latex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index 2a14b25d5..3b1fb71f2 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -956,7 +956,7 @@ URL `https://orgmode.org/worg/org-tutorials/org-latex-preview.html'."
     (tex "TeX") (latex "[LaTeX]TeX")
     (shell-script "bash")
     (gnuplot "Gnuplot")
-    (ocaml "Caml") (caml "Caml")
+    (ocaml "[Objective]Caml") (caml "Caml")
     (sql "SQL") (sqlite "sql")
     (makefile "make")
     (R "r"))
-- 
2.29.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] [Objective]Caml dialect in listings
  2021-01-14 13:24 [Patch] [Objective]Caml dialect in listings Basile Pesin
@ 2021-01-25  4:10 ` Kyle Meyer
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2021-01-25  4:10 UTC (permalink / raw)
  To: Basile Pesin; +Cc: emacs-orgmode

Basile Pesin writes:

> There is a small patch I would like to submit : when writing listings 
> for the OCaml programming language, one should use the "[Objective]Caml" 
> dialect, which is different from the "Caml" dialect. This is not 
> reflected in the latex exported code.

Makes sense.

> The attached patch changes this. Thank you in advance for your patience, 
> this is my first patch so I hope I did everything correctly.

Thanks, looks very good.  Applied (0abd4a44c) with two minor commit
message tweaks.

> Subject: [PATCH] ox-latex.el : Use [Objective]Caml dialect

I dropped the space between "el" and ":" ...

> * ox-latex.el (org-latex-listings-langs): Change the binding for
>   `ocaml' to "[Objective]Caml"
>
> The "[Objective]Caml" dialect syntax highlighting is different from the
> "Caml" one (reflecting the added features of OCaml compared to
> Caml-light).
> TINYCHANGE

... and added a new line before TINYCHANGE.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-25  4:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 13:24 [Patch] [Objective]Caml dialect in listings Basile Pesin
2021-01-25  4:10 ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).