* Build error in git HEAD with org-bibtex.el
@ 2011-04-28 11:34 Christian Egli
2011-04-28 12:53 ` Matt Lundin
2011-04-28 15:19 ` Eric Schulte
0 siblings, 2 replies; 5+ messages in thread
From: Christian Egli @ 2011-04-28 11:34 UTC (permalink / raw)
To: emacs-orgmode
Hi all
When doing a `make update` I get the following compile error:
~/src/org-mode $ make update
git pull
Already up-to-date.
/usr/bin/make clean
make[1]: Entering directory `/home/eglic/src/org-mode'
[snip]
emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-bibtex.el
In toplevel form:
lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead
make[1]: *** [lisp/org-bibtex.elc] Error 1
make[1]: Leaving directory `/home/eglic/src/org-mode'
make: *** [update] Error 2
This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.22.0) of 2011-03-04 on yellow, modified by Debian
Thanks
Christian
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in git HEAD with org-bibtex.el
2011-04-28 11:34 Build error in git HEAD with org-bibtex.el Christian Egli
@ 2011-04-28 12:53 ` Matt Lundin
2011-04-28 15:21 ` Eric Schulte
2011-04-28 15:19 ` Eric Schulte
1 sibling, 1 reply; 5+ messages in thread
From: Matt Lundin @ 2011-04-28 12:53 UTC (permalink / raw)
To: Christian Egli; +Cc: emacs-orgmode
Christian Egli <christian.egli@sbs.ch> writes:
> Hi all
>
> When doing a `make update` I get the following compile error:
>
> ~/src/org-mode $ make update
> git pull
> Already up-to-date.
> /usr/bin/make clean
> make[1]: Entering directory `/home/eglic/src/org-mode'
> [snip]
> emacs -batch -q -no-site-file -eval "(setq load-path (cons
> (expand-file-name \"./lisp/\") (cons
> \"/usr/local/share/emacs/site-lisp\" load-path)))" -f
> batch-byte-compile lisp/org-bibtex.el
>
> In toplevel form:
> lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get'
> will not work - use `labels' instead
> make[1]: *** [lisp/org-bibtex.elc] Error 1
> make[1]: Leaving directory `/home/eglic/src/org-mode'
> make: *** [update] Error 2
>
> This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version
> 2.22.0) of 2011-03-04 on yellow, modified by Debian
>
And with bleeding edge emacs (compiled from the repos yesterday), I'm
getting an additional error:
In toplevel form:
org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead
make: *** [lisp/org-bibtex.elc] Error 1
Note: the description variable error has nothing to do with the recent
changes to org-bibtex.
Best,
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in git HEAD with org-bibtex.el
2011-04-28 11:34 Build error in git HEAD with org-bibtex.el Christian Egli
2011-04-28 12:53 ` Matt Lundin
@ 2011-04-28 15:19 ` Eric Schulte
1 sibling, 0 replies; 5+ messages in thread
From: Eric Schulte @ 2011-04-28 15:19 UTC (permalink / raw)
To: Christian Egli; +Cc: emacs-orgmode
Hi Christian,
Thanks for sharing this. I've just pushed up a fix for the problem you
mentioned below. That will teach me to push a big change without
consulting the compiler first.
Best -- Eric
Christian Egli <christian.egli@sbs.ch> writes:
> Hi all
>
> When doing a `make update` I get the following compile error:
>
> ~/src/org-mode $ make update
> git pull
> Already up-to-date.
> /usr/bin/make clean
> make[1]: Entering directory `/home/eglic/src/org-mode'
> [snip]
> emacs -batch -q -no-site-file -eval "(setq load-path (cons (expand-file-name \"./lisp/\") (cons \"/usr/local/share/emacs/site-lisp\" load-path)))" -f batch-byte-compile lisp/org-bibtex.el
>
> In toplevel form:
> lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead
> make[1]: *** [lisp/org-bibtex.elc] Error 1
> make[1]: Leaving directory `/home/eglic/src/org-mode'
> make: *** [update] Error 2
>
> This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.22.0) of 2011-03-04 on yellow, modified by Debian
>
> Thanks
> Christian
--
Eric Schulte
http://cs.unm.edu/~eschulte/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in git HEAD with org-bibtex.el
2011-04-28 12:53 ` Matt Lundin
@ 2011-04-28 15:21 ` Eric Schulte
2011-04-28 15:47 ` Matt Lundin
0 siblings, 1 reply; 5+ messages in thread
From: Eric Schulte @ 2011-04-28 15:21 UTC (permalink / raw)
To: Matt Lundin; +Cc: emacs-orgmode, Christian Egli
Matt Lundin <mdl@imapmail.org> writes:
> Christian Egli <christian.egli@sbs.ch> writes:
>
>> Hi all
>>
>> When doing a `make update` I get the following compile error:
>>
>> ~/src/org-mode $ make update
>> git pull
>> Already up-to-date.
>> /usr/bin/make clean
>> make[1]: Entering directory `/home/eglic/src/org-mode'
>> [snip]
>> emacs -batch -q -no-site-file -eval "(setq load-path (cons
>> (expand-file-name \"./lisp/\") (cons
>> \"/usr/local/share/emacs/site-lisp\" load-path)))" -f
>> batch-byte-compile lisp/org-bibtex.el
>>
>> In toplevel form:
>> lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get'
>> will not work - use `labels' instead
>> make[1]: *** [lisp/org-bibtex.elc] Error 1
>> make[1]: Leaving directory `/home/eglic/src/org-mode'
>> make: *** [update] Error 2
>>
>> This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version
>> 2.22.0) of 2011-03-04 on yellow, modified by Debian
>>
>
> And with bleeding edge emacs (compiled from the repos yesterday), I'm
> getting an additional error:
>
> In toplevel form:
> org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
> org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead
> make: *** [lisp/org-bibtex.elc] Error 1
>
> Note: the description variable error has nothing to do with the recent
> changes to org-bibtex.
>
Hi Matt,
Yes, the org-mode source is littered with such un-prefixed dynamic
variables, and I'm not sure how this will be addressed. Personally I
would prefer an option to tell the compiler not to complain, as adding
org- to all of these variable names could make the source harder to
read. But, that said, I suppose there is a danger of conflict in common
variable names between packages...
Thanks -- Eric
>
> Best,
> Matt
>
>
--
Eric Schulte
http://cs.unm.edu/~eschulte/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in git HEAD with org-bibtex.el
2011-04-28 15:21 ` Eric Schulte
@ 2011-04-28 15:47 ` Matt Lundin
0 siblings, 0 replies; 5+ messages in thread
From: Matt Lundin @ 2011-04-28 15:47 UTC (permalink / raw)
To: Eric Schulte; +Cc: Christian Egli, emacs-orgmode
"Eric Schulte" <schulte.eric@gmail.com> writes:
> Matt Lundin <mdl@imapmail.org> writes:
>
[...]
>> And with bleeding edge emacs (compiled from the repos yesterday), I'm
>> getting an additional error:
>>
>> In toplevel form:
>> org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
>> org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get'
>> will not work - use `labels' instead
>> make: *** [lisp/org-bibtex.elc] Error 1
>>
>> Note: the description variable error has nothing to do with the recent
>> changes to org-bibtex.
>
> Yes, the org-mode source is littered with such un-prefixed dynamic
> variables, and I'm not sure how this will be addressed. Personally I
> would prefer an option to tell the compiler not to complain, as adding
> org- to all of these variable names could make the source harder to
> read. But, that said, I suppose there is a danger of conflict in common
> variable names between packages...
Thanks for explaining this. I believe I misspoke when I said it was an
error. I now see it is only a warning.
Best,
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-28 15:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-28 11:34 Build error in git HEAD with org-bibtex.el Christian Egli
2011-04-28 12:53 ` Matt Lundin
2011-04-28 15:21 ` Eric Schulte
2011-04-28 15:47 ` Matt Lundin
2011-04-28 15:19 ` Eric Schulte
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).