emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org, Christian Egli <christian.egli@sbs.ch>
Subject: Re: Build error in git HEAD with org-bibtex.el
Date: Thu, 28 Apr 2011 09:21:37 -0600	[thread overview]
Message-ID: <87tydibdvi.fsf@gmail.com> (raw)
In-Reply-To: <87vcxyv8o4.fsf@fastmail.fm> (Matt Lundin's message of "Thu, 28 Apr 2011 08:53:47 -0400")

Matt Lundin <mdl@imapmail.org> writes:

> Christian Egli <christian.egli@sbs.ch> writes:
>
>> Hi all
>>
>> When doing a `make update` I get the following compile error:
>>
>> ~/src/org-mode $ make update
>> git pull
>> Already up-to-date.
>> /usr/bin/make clean
>> make[1]: Entering directory `/home/eglic/src/org-mode'
>> [snip]
>> emacs -batch -q -no-site-file -eval "(setq load-path (cons
>> (expand-file-name \"./lisp/\") (cons
>> \"/usr/local/share/emacs/site-lisp\" load-path)))" -f
>> batch-byte-compile lisp/org-bibtex.el
>>
>> In toplevel form:
>> lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get'
>> will not work - use `labels' instead
>> make[1]: *** [lisp/org-bibtex.elc] Error 1
>> make[1]: Leaving directory `/home/eglic/src/org-mode'
>> make: *** [update] Error 2
>>
>> This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version
>> 2.22.0) of 2011-03-04 on yellow, modified by Debian
>>
>
> And with bleeding edge emacs (compiled from the repos yesterday), I'm
> getting an additional error:
>
> In toplevel form:
> org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix
> org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead
> make: *** [lisp/org-bibtex.elc] Error 1
>
> Note: the description variable error has nothing to do with the recent
> changes to org-bibtex.
>

Hi Matt,

Yes, the org-mode source is littered with such un-prefixed dynamic
variables, and I'm not sure how this will be addressed.  Personally I
would prefer an option to tell the compiler not to complain, as adding
org- to all of these variable names could make the source harder to
read.  But, that said, I suppose there is a danger of conflict in common
variable names between packages...

Thanks -- Eric

>
> Best,
> Matt
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2011-04-28 15:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 11:34 Build error in git HEAD with org-bibtex.el Christian Egli
2011-04-28 12:53 ` Matt Lundin
2011-04-28 15:21   ` Eric Schulte [this message]
2011-04-28 15:47     ` Matt Lundin
2011-04-28 15:19 ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tydibdvi.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=christian.egli@sbs.ch \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).