From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] babel: ob-C with Visual C++ and compilation-mode
Date: Wed, 10 Sep 2014 11:27:36 +0200 [thread overview]
Message-ID: <87vbovj053.fsf@Rainer.invalid> (raw)
In-Reply-To: 87tx4w4qkj.fsf@gmail.com
Eric Schulte writes:
> Ernesto Durante <stobossey@gmail.com> writes:
>> + First patch, modify org-babel-eval to load compilation-mode in case
>>of errors
>>
>
> Applied.
These are missing a proper changelog so Bastien will be less happy.
>> org-babel-eval: compilation-mode to deal with errors in (C/C++/D)
Despite the title, the change is implemented for all Babel error
buffers. I'm not sure that's the right thing to do, but I don't see
off-hand how to easily make this a per-language setting.
>> + (compilation-mode)
Setting a mode from within lisp is pretty heavy-handed. Since we're
calling upon an existing buffer we should check if it's already in that
mode.
>> + ;;compilation-mode enforces read-only
>> + (read-only-mode 0))))
That doesn't work on Emacs < 24.3 and does a few other things that again
should not be done from Lisp. I'll change this to just
(setq buffer-read-only nil)
but compilation mode in an editable buffer is somewhat strange. Instead
we should probably bind (inhibit-read-only t) around those places where
Babel wants to modify the buffer, but I'm not sure how to easily find
them all.
(Done in ec8f245.)
Regards
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
prev parent reply other threads:[~2014-09-10 9:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 16:16 babel: ob-C with Visual C++ and compilation-mode Ernesto Durante
2014-08-11 19:40 ` Thierry Banel
2014-08-12 14:24 ` Ernesto Durante
2014-08-12 22:03 ` Thierry Banel
2014-08-13 20:58 ` Ernesto Durante
2014-08-14 20:40 ` Thierry Banel
2014-08-15 17:22 ` Ernesto Durante
2014-08-17 11:20 ` Thierry Banel
2014-08-18 11:19 ` Ernesto Durante
2014-08-18 12:51 ` Eric Schulte
2014-08-24 13:05 ` Ernesto Durante
2014-08-28 14:02 ` Eric Schulte
2014-08-18 19:59 ` Thierry Banel
2014-08-20 20:40 ` Ernesto Durante
2014-08-21 19:48 ` Thierry Banel
2014-08-24 12:57 ` Ernesto Durante
2014-08-28 19:44 ` Thierry Banel
2014-08-18 2:41 ` Eric Schulte
2014-08-18 2:40 ` Eric Schulte
2014-08-23 11:03 ` Ernesto Durante
2014-08-25 16:35 ` [PATCH] " Ernesto Durante
2014-08-28 14:46 ` Eric Schulte
2014-09-10 9:27 ` Achim Gratz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbovj053.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).