From: "Łukasz Stelmach" <lukasz.stelmach@iem.pw.edu.pl>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] little fixes for attachment git commiting
Date: Fri, 19 Feb 2010 12:51:15 +0100 [thread overview]
Message-ID: <87tytdtpe4.fsf@dasa3.iem.pw.edu.pl> (raw)
In-Reply-To: C07A2B2E-B523-418D-BA3A-6E9743A3CCB1@gmail.com
Carsten Dominik <carsten.dominik@gmail.com> writes:
> On Feb 19, 2010, at 11:59 AM, Łukasz Stelmach wrote:
>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> On Feb 16, 2010, at 8:04 PM, Łukasz Stelmach wrote:
>>>
>>>> There are two very small commits which iron some wrinkles. Both on
>>>> org-attach-git-commit branch of
>>>> git://github.com/steelman/steelman-org-mode.git
>>>>
>>>> The first prevents git from running on an empty set of deleted
>>>> files.
>>>
>>> Why is that a problem? I am hesitating to apply this patch, because
>>> on my Mac OS 10.5, xargs does know the --no-run-if-empty argument.
>> ^^^^^^^^^[*]
>>
>> When xargs launches git rm without file arguments git emmits usage
>>
>> --8<---------------cut here---------------start------------->8---
>> usage: git rm [options] [--] <file>...
[...]
>> --8<---------------cut here---------------end--------------->8---
>>
>> message which in this situation is a bit confusing and *suggests*
>> somehting might have gone wrong. And of course a shell output buffer
>> pops up.
>>
>> [*] does || doesn't?
>
> Does not.
>
> Do you actually get to see this error message? Where?
Everytime I attach a file and there is no deleted files which "git
ls-files --deleted" would list. Try running
git ls-files --deleted -z | xargs -0 git rm
when there is no deleted uncommited files in a repository. git's return
code is 123 so Emacs thinks it is an error.
--
Miłego dnia,
Łukasz Stelmach
next prev parent reply other threads:[~2010-02-19 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 19:04 [PATCH] little fixes for attachment git commiting Łukasz Stelmach
2010-02-16 20:25 ` David Maus
2010-02-16 21:33 ` Łukasz Stelmach
2010-02-17 8:04 ` David Maus
2010-02-17 11:09 ` Łukasz Stelmach
2010-02-18 20:11 ` David Maus
2010-02-19 8:46 ` Carsten Dominik
2010-02-19 10:59 ` Łukasz Stelmach
2010-02-19 11:03 ` Carsten Dominik
2010-02-19 11:51 ` Łukasz Stelmach [this message]
2010-03-09 16:04 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tytdtpe4.fsf@dasa3.iem.pw.edu.pl \
--to=lukasz.stelmach@iem.pw.edu.pl \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).