emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Łukasz Stelmach" <lukasz.stelmach@iem.pw.edu.pl>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] little fixes for attachment git commiting
Date: Wed, 17 Feb 2010 12:09:48 +0100	[thread overview]
Message-ID: <87hbpg15kz.fsf@dasa3.iem.pw.edu.pl> (raw)
In-Reply-To: 874olg2sqf.wl%maus.david@gmail.com

David Maus <maus.david@gmail.com> writes:

> Łukasz Stelmach wrote:
>>David Maus <maus.david@gmail.com> writes:
>
>>> Łukasz Stelmach wrote:
>>>>The other one helps if for some reason the file one would like to add
>>>>matches an entry in a .gitignore file. I suppose no one puts anything in
>>>>the org-attach-directory by hand, so anything that goes there is by
>>>>intention.
>>>>http://github.com/steelman/steelman-org-mode/commit/8ade081fd5a331cc61f8f8a6f8cf5a92ff8881d5
>>>
[...]
>>> In addition one might explicitly include the content of attachment
>>> directories using the negating operator in .gitignore.
>>This might be a better solution indeed.
>
> Yep.  Though about it: Using the -f switch overrides any configuration
> of git a user may have made in a system wide, user or repository
> specific gitignore -- that shouldn't be turned on by default or even
> enforced in the source.

You're right, I admit. Please forget this commit. Take only the one
about xargs --no-run-if-empty

http://github.com/steelman/steelman-org-mode/commit/8dc5033d13af1d0aa6f1094a1775cc1a1ec33c67

>>I'll investigate it a little bit closer.
>
> Just an idea: Why not add hooks that are called after certain
> attachment operations (add, remove, update)?  This way we could
> decouple a (specific) use of git or even of git itself.

That's a little more hacking that I'd like to do now. Anyone?

> Some other thing: As far as I understood the source an error while
> synchronizing the attachment directory is indiciated in the "*Shell
> Command Output*" buffer and the miniprompt.  I'm not sure if this
> should be considered sufficient or not.

It's been enough for me to start investigating. It depends on how
userfriendly orgmode is supposed to be.
-- 
Miłego dnia,
Łukasz Stelmach

  reply	other threads:[~2010-02-17 11:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 19:04 [PATCH] little fixes for attachment git commiting Łukasz Stelmach
2010-02-16 20:25 ` David Maus
2010-02-16 21:33   ` Łukasz Stelmach
2010-02-17  8:04     ` David Maus
2010-02-17 11:09       ` Łukasz Stelmach [this message]
2010-02-18 20:11         ` David Maus
2010-02-19  8:46 ` Carsten Dominik
2010-02-19 10:59   ` Łukasz Stelmach
2010-02-19 11:03     ` Carsten Dominik
2010-02-19 11:51       ` Łukasz Stelmach
2010-03-09 16:04         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbpg15kz.fsf@dasa3.iem.pw.edu.pl \
    --to=lukasz.stelmach@iem.pw.edu.pl \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).