From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?=C5=81ukasz_Stelmach?= Subject: Re: [PATCH] little fixes for attachment git commiting Date: Wed, 17 Feb 2010 12:09:48 +0100 Message-ID: <87hbpg15kz.fsf@dasa3.iem.pw.edu.pl> References: <87635xuhnd.fsf@dasa3.iem.pw.edu.pl> <871vglrkr4.wl%maus.david@gmail.com> <87y6isj27f.fsf@dasa3.iem.pw.edu.pl> <874olg2sqf.wl%maus.david@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhhnP-0004iI-Lw for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 06:10:19 -0500 Received: from [140.186.70.92] (port=35213 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhhnO-0004iA-Mx for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 06:10:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NhhnN-00049R-JE for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 06:10:18 -0500 Received: from lo.gmane.org ([80.91.229.12]:34341) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NhhnN-00049L-8w for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 06:10:17 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NhhnG-0004qN-4n for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 12:10:10 +0100 Received: from dasa3.iem.pw.edu.pl ([194.29.147.110]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 17 Feb 2010 12:10:10 +0100 Received: from lukasz.stelmach by dasa3.iem.pw.edu.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 17 Feb 2010 12:10:10 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org David Maus writes: > Łukasz Stelmach wrote: >>David Maus writes: > >>> Łukasz Stelmach wrote: >>>>The other one helps if for some reason the file one would like to add >>>>matches an entry in a .gitignore file. I suppose no one puts anything in >>>>the org-attach-directory by hand, so anything that goes there is by >>>>intention. >>>>http://github.com/steelman/steelman-org-mode/commit/8ade081fd5a331cc61f8f8a6f8cf5a92ff8881d5 >>> [...] >>> In addition one might explicitly include the content of attachment >>> directories using the negating operator in .gitignore. >>This might be a better solution indeed. > > Yep. Though about it: Using the -f switch overrides any configuration > of git a user may have made in a system wide, user or repository > specific gitignore -- that shouldn't be turned on by default or even > enforced in the source. You're right, I admit. Please forget this commit. Take only the one about xargs --no-run-if-empty http://github.com/steelman/steelman-org-mode/commit/8dc5033d13af1d0aa6f1094a1775cc1a1ec33c67 >>I'll investigate it a little bit closer. > > Just an idea: Why not add hooks that are called after certain > attachment operations (add, remove, update)? This way we could > decouple a (specific) use of git or even of git itself. That's a little more hacking that I'd like to do now. Anyone? > Some other thing: As far as I understood the source an error while > synchronizing the attachment directory is indiciated in the "*Shell > Command Output*" buffer and the miniprompt. I'm not sure if this > should be considered sufficient or not. It's been enough for me to start investigating. It depends on how userfriendly orgmode is supposed to be. -- Miłego dnia, Łukasz Stelmach