From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?=C5=81ukasz_Stelmach?= Subject: Re: [PATCH] little fixes for attachment git commiting Date: Fri, 19 Feb 2010 12:51:15 +0100 Message-ID: <87tytdtpe4.fsf@dasa3.iem.pw.edu.pl> References: <87635xuhnd.fsf@dasa3.iem.pw.edu.pl> <0E4FD6B3-1912-4A6B-96A1-0CF00B3EAED1@gmail.com> <873a0xv6c2.fsf@dasa3.iem.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiROY-0006Ih-Kj for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:51:42 -0500 Received: from [140.186.70.92] (port=39187 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiROV-0006Ei-Vf for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:51:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiROU-0002qx-QP for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:51:39 -0500 Received: from lo.gmane.org ([80.91.229.12]:45331) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiROU-0002qq-D1 for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 06:51:38 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NiROT-0005Q0-M8 for emacs-orgmode@gnu.org; Fri, 19 Feb 2010 12:51:37 +0100 Received: from dasa3.iem.pw.edu.pl ([194.29.147.110]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Feb 2010 12:51:37 +0100 Received: from lukasz.stelmach by dasa3.iem.pw.edu.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Feb 2010 12:51:37 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Carsten Dominik writes: > On Feb 19, 2010, at 11:59 AM, Łukasz Stelmach wrote: > >> Carsten Dominik writes: >> >>> On Feb 16, 2010, at 8:04 PM, Łukasz Stelmach wrote: >>> >>>> There are two very small commits which iron some wrinkles. Both on >>>> org-attach-git-commit branch of >>>> git://github.com/steelman/steelman-org-mode.git >>>> >>>> The first prevents git from running on an empty set of deleted >>>> files. >>> >>> Why is that a problem? I am hesitating to apply this patch, because >>> on my Mac OS 10.5, xargs does know the --no-run-if-empty argument. >> ^^^^^^^^^[*] >> >> When xargs launches git rm without file arguments git emmits usage >> >> --8<---------------cut here---------------start------------->8--- >> usage: git rm [options] [--] ... [...] >> --8<---------------cut here---------------end--------------->8--- >> >> message which in this situation is a bit confusing and *suggests* >> somehting might have gone wrong. And of course a shell output buffer >> pops up. >> >> [*] does || doesn't? > > Does not. > > Do you actually get to see this error message? Where? Everytime I attach a file and there is no deleted files which "git ls-files --deleted" would list. Try running git ls-files --deleted -z | xargs -0 git rm when there is no deleted uncommited files in a repository. git's return code is 123 so Emacs thinks it is an error. -- Miłego dnia, Łukasz Stelmach