* [maint bug, org-clock.el] org-time-string-to-seconds
@ 2017-09-01 9:01 Rasmus
0 siblings, 0 replies; 5+ messages in thread
From: Rasmus @ 2017-09-01 9:01 UTC (permalink / raw)
To: emacs-orgmode
Hi,
There’s bug in maint that made it into Org v9.0.10 via commit
7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1
signature of ‘org-time-string-to-seconds’ has made it into
‘org-clock-sum’. Should I just remove the time zone, or should the
signature of ‘org-time-string-to-seconds’ be changed in maint?
Rasmus
--
And when I’m finished thinking, I have to die a lot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [maint bug, org-clock.el] org-time-string-to-seconds
@ 2017-09-01 9:02 Rasmus
2017-09-01 15:18 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Rasmus @ 2017-09-01 9:02 UTC (permalink / raw)
To: emacs-orgmode
Hi,
There’s bug in maint that made it into Org v9.0.10 via commit
7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1
signature of ‘org-time-string-to-seconds’ has made it into
‘org-clock-sum’. Should I just remove the time zone, or should the
signature of ‘org-time-string-to-seconds’ be changed in maint?
Rasmus
--
And when I’m finished thinking, I have to die a lot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [maint bug, org-clock.el] org-time-string-to-seconds
2017-09-01 9:02 Rasmus
@ 2017-09-01 15:18 ` Nicolas Goaziou
2017-09-02 1:01 ` Adam Porter
2017-09-04 8:26 ` Rasmus
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2017-09-01 15:18 UTC (permalink / raw)
To: Rasmus; +Cc: emacs-orgmode
Hello,
Rasmus <rasmus@gmx.us> writes:
> There’s bug in maint that made it into Org v9.0.10 via commit
> 7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1
> signature of ‘org-time-string-to-seconds’ has made it into
> ‘org-clock-sum’. Should I just remove the time zone, or should the
> signature of ‘org-time-string-to-seconds’ be changed in maint?
Considering Org 9.1 is (hopefully) about to be released, I wouldn't
bother much.
I think the original idea was to change the signature in maint.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [maint bug, org-clock.el] org-time-string-to-seconds
2017-09-01 15:18 ` Nicolas Goaziou
@ 2017-09-02 1:01 ` Adam Porter
2017-09-04 8:26 ` Rasmus
1 sibling, 0 replies; 5+ messages in thread
From: Adam Porter @ 2017-09-02 1:01 UTC (permalink / raw)
To: emacs-orgmode
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Rasmus <rasmus@gmx.us> writes:
>
>> There’s bug in maint that made it into Org v9.0.10 via commit
>> 7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1
>> signature of ‘org-time-string-to-seconds’ has made it into
>> ‘org-clock-sum’. Should I just remove the time zone, or should the
>> signature of ‘org-time-string-to-seconds’ be changed in maint?
>
> Considering Org 9.1 is (hopefully) about to be released, I wouldn't
> bother much.
>
> I think the original idea was to change the signature in maint.
>
> Regards,
FYI this is the bug mentioned in an earlier thread and here:
https://github.com/Fuco1/org-clock-budget/issues/5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [maint bug, org-clock.el] org-time-string-to-seconds
2017-09-01 15:18 ` Nicolas Goaziou
2017-09-02 1:01 ` Adam Porter
@ 2017-09-04 8:26 ` Rasmus
1 sibling, 0 replies; 5+ messages in thread
From: Rasmus @ 2017-09-04 8:26 UTC (permalink / raw)
To: emacs-orgmode
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Rasmus <rasmus@gmx.us> writes:
>
>> There’s bug in maint that made it into Org v9.0.10 via commit
>> 7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1
>> signature of ‘org-time-string-to-seconds’ has made it into
>> ‘org-clock-sum’. Should I just remove the time zone, or should the
>> signature of ‘org-time-string-to-seconds’ be changed in maint?
>
> Considering Org 9.1 is (hopefully) about to be released, I wouldn't
> bother much.
OK, let’s give v9.1 a bit of time to finish. If v9.0.10 isn’t widely used
after this release I see no issue with it.
> I think the original idea was to change the signature in maint.
OK.
Thanks,
Rasmus
--
ツ
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-04 8:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 9:01 [maint bug, org-clock.el] org-time-string-to-seconds Rasmus
-- strict thread matches above, loose matches on Subject: below --
2017-09-01 9:02 Rasmus
2017-09-01 15:18 ` Nicolas Goaziou
2017-09-02 1:01 ` Adam Porter
2017-09-04 8:26 ` Rasmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).