From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [maint bug, org-clock.el] org-time-string-to-seconds Date: Mon, 04 Sep 2017 10:26:43 +0200 Message-ID: <871snmj2d8.fsf@gmx.us> References: <87shg6iyfw.fsf@gmx.us> <87val230rx.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1domit-0007oW-4e for emacs-orgmode@gnu.org; Mon, 04 Sep 2017 04:27:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1domip-0000Pl-57 for emacs-orgmode@gnu.org; Mon, 04 Sep 2017 04:27:11 -0400 Received: from [195.159.176.226] (port=39966 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1domio-0000Ol-U8 for emacs-orgmode@gnu.org; Mon, 04 Sep 2017 04:27:07 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1domiZ-0003Ue-QI for emacs-orgmode@gnu.org; Mon, 04 Sep 2017 10:26:51 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Rasmus writes: > >> There’s bug in maint that made it into Org v9.0.10 via commit >> 7e241af591df15d2b7587648ed2342ae3a5d0e5b. In org-clock.el, the v9.1 >> signature of ‘org-time-string-to-seconds’ has made it into >> ‘org-clock-sum’. Should I just remove the time zone, or should the >> signature of ‘org-time-string-to-seconds’ be changed in maint? > > Considering Org 9.1 is (hopefully) about to be released, I wouldn't > bother much. OK, let’s give v9.1 a bit of time to finish. If v9.0.10 isn’t widely used after this release I see no issue with it. > I think the original idea was to change the signature in maint. OK. Thanks, Rasmus -- ツ