From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: org-pop-mode
Date: Wed, 18 Mar 2020 15:24:21 -0500 [thread overview]
Message-ID: <87sgi5za16.fsf@alphapapa.net> (raw)
In-Reply-To: af32f000-436c-cc33-7501-918d1a8c3ef5@kli.org
"Mark E. Shoulson" <mark@shoulson.com> writes:
> Heh; fair enough. The filename originally was "org-level-end.el", I
> think; I started using the catchier "org-pop" because... well, it was
> catchier. It made sense in my mind, in the "push"/"pop" sense used
> with stacks in programming, that you "push" to a deeper level and this
> library would allow you to "pop" back up to a higher one. I'll see if
> I can think of something better, thanks.
Well, org-heading-push-pop wouldn't be a /great/ name, but the push/pop
paradigm is understandable, so you might consider that. :)
>
>> 2. In the code, I saw you comment about cl-flet, and I see you using
>> fset and unwind-protect in the org-pop-with-continuations macro.
>> Instead, use cl-letf with symbol-function, like:
>>
>> (cl-letf* (((symbol-function 'foo)
>> #'my-foo)
>> ((symbol-function 'bar)
>> (lambda ()
>> ...)))
>> BODY)
>>
>> See also Nic Ferrier's package, noflet.
>
> I'll take a look, thanks. It's questionable whether I really should
> even be messing about with that macro anyway. I musnt have removed the
> comments, but I had a whole thing there about how I had been trying
> with cl-letf and/or cl-flet and it didn't work. Thing is, cl-flet,
> according to the docs, (info:cl#Function Bindings) is strictly
> *lexical* binding, which is not going to cut it. cl-letf might be
> different; the docs are different about it, but I am pretty sure I
> tried it and it didn't work, or didn't work "enough of the time." But
> maybe I had it wrong, and maybe noflet will succeed.
The issue is what the macros expand to. cl-letf rebinds the function
symbols, just like fset, so it affects all code that runs in Emacs until
the function symbols are set again. cl-flet expands into lambdas bound
to variables and replaces calls to them with funcall, so it only affects
calls in the macro's body. Use pp-macroexpand-last-sexp to see the
expansions.
BTW, in the body of your email, the text you write has these two
characters between sentences: " ". The second is a plain space, but
the first is a Unicode non-breaking space, or "C-x 8 RET a0". I noticed
because it's displayed in Emacs as an underline character next to the
plain space.
next prev parent reply other threads:[~2020-03-18 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 2:33 org-pop-mode Mark E. Shoulson
2020-03-18 7:00 ` org-pop-mode Ihor Radchenko
2020-03-18 19:57 ` org-pop-mode Mark E. Shoulson
2020-03-22 14:58 ` org-pop-mode Mark E. Shoulson
2020-03-22 18:15 ` org-pop-mode Ihor Radchenko
2020-03-18 19:15 ` org-pop-mode Adam Porter
2020-03-18 20:05 ` org-pop-mode Mark E. Shoulson
2020-03-18 20:24 ` Adam Porter [this message]
2020-03-18 20:52 ` org-pop-mode Mark E. Shoulson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgi5za16.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).