emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: org-pop-mode
Date: Wed, 18 Mar 2020 14:15:47 -0500	[thread overview]
Message-ID: <87wo7hzd7g.fsf@alphapapa.net> (raw)
In-Reply-To: 7d38c66d-6ea5-ff8f-ee39-142c8dbdcd18@kli.org

"Mark E. Shoulson" <mark@shoulson.com> writes:

> This is something I've wanted for years in org-mode, but which in some
> ways could actually be _offensive_ to its ideals.  If you're an
> outline purist, look away.
>
> ...
>
> So, I present a pre-alpha version,
> https://gist.github.com/clsn/09ac4b098b6ad7366bb5e0bc88882d5f of
> org-pop-mode.  To "pop" back up, create a headline at the level you're
> popping back to, and give it a tag of "contd", and the headline text
> should not be something important.  Instructions and explanations are
> in the comments of the file (the part about installing from MELPA is a
> lie, though).
>
> Any feedback?

Hi Mark,

Indeed, this is something that is frequently asked about.  I probably
wouldn't use it myself, but it looks like you've done a good job on it.
Here is some feedback:

1.  I'd suggest a more descriptive name, especially if you plan to
publish it to MELPA.  org-pop doesn't seem to convey anything about what
it does.  :)

2.  In the code, I saw you comment about cl-flet, and I see you using
fset and unwind-protect in the org-pop-with-continuations macro.
Instead, use cl-letf with symbol-function, like:

  (cl-letf* (((symbol-function 'foo)
              #'my-foo)
             ((symbol-function 'bar)
              (lambda ()
                ...)))
    BODY)

See also Nic Ferrier's package, noflet.

  parent reply	other threads:[~2020-03-18 19:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  2:33 org-pop-mode Mark E. Shoulson
2020-03-18  7:00 ` org-pop-mode Ihor Radchenko
2020-03-18 19:57   ` org-pop-mode Mark E. Shoulson
2020-03-22 14:58   ` org-pop-mode Mark E. Shoulson
2020-03-22 18:15     ` org-pop-mode Ihor Radchenko
2020-03-18 19:15 ` Adam Porter [this message]
2020-03-18 20:05   ` org-pop-mode Mark E. Shoulson
2020-03-18 20:24     ` org-pop-mode Adam Porter
2020-03-18 20:52       ` org-pop-mode Mark E. Shoulson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo7hzd7g.fsf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).