From: "Mark E. Shoulson" <mark@shoulson.com>
To: emacs-orgmode@gnu.org
Subject: Re: org-pop-mode
Date: Wed, 18 Mar 2020 16:05:53 -0400 [thread overview]
Message-ID: <af32f000-436c-cc33-7501-918d1a8c3ef5@kli.org> (raw)
In-Reply-To: <87wo7hzd7g.fsf@alphapapa.net>
On 3/18/20 3:15 PM, Adam Porter wrote:
> "Mark E. Shoulson" <mark@shoulson.com> writes:
>
>> This is something I've wanted for years in org-mode, but which in some
>> ways could actually be _offensive_ to its ideals. If you're an
>> outline purist, look away.
>>
>> ...
>>
>> So, I present a pre-alpha version,
>> https://gist.github.com/clsn/09ac4b098b6ad7366bb5e0bc88882d5f of
>> org-pop-mode. To "pop" back up, create a headline at the level you're
>> popping back to, and give it a tag of "contd", and the headline text
>> should not be something important. Instructions and explanations are
>> in the comments of the file (the part about installing from MELPA is a
>> lie, though).
>>
>> Any feedback?
> Hi Mark,
>
> Indeed, this is something that is frequently asked about. I probably
> wouldn't use it myself, but it looks like you've done a good job on it.
> Here is some feedback:
>
> 1. I'd suggest a more descriptive name, especially if you plan to
> publish it to MELPA. org-pop doesn't seem to convey anything about what
> it does. :)
Heh; fair enough. The filename originally was "org-level-end.el", I
think; I started using the catchier "org-pop" because... well, it was
catchier. It made sense in my mind, in the "push"/"pop" sense used with
stacks in programming, that you "push" to a deeper level and this
library would allow you to "pop" back up to a higher one. I'll see if I
can think of something better, thanks.
> 2. In the code, I saw you comment about cl-flet, and I see you using
> fset and unwind-protect in the org-pop-with-continuations macro.
> Instead, use cl-letf with symbol-function, like:
>
> (cl-letf* (((symbol-function 'foo)
> #'my-foo)
> ((symbol-function 'bar)
> (lambda ()
> ...)))
> BODY)
>
> See also Nic Ferrier's package, noflet.
I'll take a look, thanks. It's questionable whether I really should
even be messing about with that macro anyway. I must have removed the
comments, but I had a whole thing there about how I had been trying with
cl-letf and/or cl-flet and it didn't work. Thing is, cl-flet, according
to the docs, (info:cl#Function Bindings) is strictly *lexical* binding,
which is not going to cut it. cl-letf might be different; the docs are
different about it, but I am pretty sure I tried it and it didn't work,
or didn't work "enough of the time." But maybe I had it wrong, and
maybe noflet will succeed.
Thanks!
~mark
next prev parent reply other threads:[~2020-03-18 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 2:33 org-pop-mode Mark E. Shoulson
2020-03-18 7:00 ` org-pop-mode Ihor Radchenko
2020-03-18 19:57 ` org-pop-mode Mark E. Shoulson
2020-03-22 14:58 ` org-pop-mode Mark E. Shoulson
2020-03-22 18:15 ` org-pop-mode Ihor Radchenko
2020-03-18 19:15 ` org-pop-mode Adam Porter
2020-03-18 20:05 ` Mark E. Shoulson [this message]
2020-03-18 20:24 ` org-pop-mode Adam Porter
2020-03-18 20:52 ` org-pop-mode Mark E. Shoulson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af32f000-436c-cc33-7501-918d1a8c3ef5@kli.org \
--to=mark@shoulson.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).