emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Shankar Rao <shankar.rao@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] New function org-speed-command-add for adding/modifying speed commands
Date: Wed, 18 May 2022 21:12:06 +0800	[thread overview]
Message-ID: <87sfp70yu1.fsf@localhost> (raw)
In-Reply-To: <CAGEgU=j_idDyXGcnqTsqCzGYCFGGVzT4YrKYFoBeqrq3SAS9ng@mail.gmail.com>

Shankar Rao <shankar.rao@gmail.com> writes:

> Using ``org-speed-command-add'', I don't have to be concerned with
> whether or not a given key is already present in
> ``org-speed-commands''.

Sure. However, the same can be achieved with fairly simple Elisp, as you
saw in the earlier messages. I do not clearly see how a significant
number of users can really benefit from this command. Most people will
simply not notice it. Beginners should better use customize interface.
Power users can just write elisp.

The only way I can see the proposed approach useful is creating a
unified framework to set various non-trivial Org options programatically
(like org-agenda-custom-commands). I would be in favour of merging such
framework, but not individual commands. Having convenience setters for
some customisations, but not other will be just confusing. Org already
has a huge number of cusomisations.

Alternatively, if many people jump in and say that your idea is very for
them, the patch can be merged.

> I agree that ``org-speed-command-add'' has undefined behavior when
> provided with only a descriptive headline as its first element. Would
> you be more amenable to this command if it either ignored or
> explicitly disallowed descriptive headline entries?

There is not much point discussing this part given the above issue I
raised.

Best,
Ihor



      reply	other threads:[~2022-05-18 13:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24  9:36 Unintended consequences of removing org-speed-commands-user Shankar Rao
2021-11-28 12:15 ` dal-blazej
2021-11-30 12:13   ` Shankar Rao
2021-11-30 14:19 ` [PATCH] New function org-speed-command-add for adding/modifying speed commands Shankar Rao
2022-05-03 10:24   ` Ihor Radchenko
2022-05-17 13:01     ` Shankar Rao
2022-05-18 13:12       ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfp70yu1.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=shankar.rao@gmail.com \
    --subject='Re: [PATCH] New function org-speed-command-add for adding/modifying speed commands' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).