From: Shankar Rao <email@example.com> To: Ihor Radchenko <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] New function org-speed-command-add for adding/modifying speed commands Date: Tue, 17 May 2022 15:01:45 +0200 [thread overview] Message-ID: <CAGEgU=j_idDyXGcnqTsqCzGYCFGGVzT4YrKYFoBeqrq3SAS9ng@mail.gmail.com> (raw) In-Reply-To: <87bkwe52yj.fsf@localhost> Thank you for looking into this. As you recommended, I tried modifying ``org-speed-commands'' using the customize interface. While it did enable me to configure and organize ``org-speed-commands'' in just the way I would like, I found using the customize interface to be a bit cumbersome. Using the customize interface, for each command that I wished to add, I had to visually scan over the whole structure of ``org-speed-commands'' to see if the key for this command was already present in the list, and replace it with my command if it is, or prepend my command to the top of the list if not it was already present. Then after I saved the customization, it added the whole new value of ``org-speed-commands'' to the end of my init.el, making it more cluttered. Alternatively using my ``org-speed-command-add'' requires me to add a single command to my init.el containing only my modifications: (org-speed-command-add '(("N" . ded-org-show-next-heading-tidily) ("P" . ded-org-show-previous-heading-tidily) ("h" . sbr-org-speed-insert-subheading) ("f" . org-forward-heading-or-item) ("b" . org-backward-heading-or-item) ("u" . org-up-heading-or-item) ("n" . org-next-heading-or-item) ("p" . org-prev-heading-or-item))) Using ``org-speed-command-add'', I don't have to be concerned with whether or not a given key is already present in ``org-speed-commands''. I agree that ``org-speed-command-add'' has undefined behavior when provided with only a descriptive headline as its first element. Would you be more amenable to this command if it either ignored or explicitly disallowed descriptive headline entries? Shankar On Tue, May 3, 2022 at 12:23 PM Ihor Radchenko <firstname.lastname@example.org> wrote: > > Shankar Rao <email@example.com> writes: > > > Over the weekend I thought about this issue of configuring > > `org-speed-commands' more easily, and I believe I have come up with a > > simpler solution that I have provided in the attached patch. > > > > This patch creates a new function `org-speed-command-add' that can be > > used to add new speed command shortcuts to `org-speed-commands', as > > well as modify existing shortcuts. This function takes as argument an > > alist in the same format as `org-speed-commands'. For each command for > > which the shortcut key is already present in `org-speed-commands', the > > old command is replaced with the new command at the same position. > > Commands with brand new shortcut keys are added to the user section of > > `org-speed-commands'. > > > > I believe this patch strikes a balance between power users, who can > > still directly customize `org-speed-commands', and non-experts, who > > may want to add/modify some speed commands without having to > > understand the structure and organization of `org-speed-commands'. > > I am not sure about usefulness of the proposed command. For non-power > users, we have cusomize interface. It should work just fine without a > need to introduce another function. > > Also, org-speed-command-add may behave strangely if the argument > contains descriptive headline like ("My command group title") as its > first element. > > Best, > Ihor
next prev parent reply other threads:[~2022-05-17 13:56 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-24 9:36 Unintended consequences of removing org-speed-commands-user Shankar Rao 2021-11-28 12:15 ` dal-blazej 2021-11-30 12:13 ` Shankar Rao 2021-11-30 14:19 ` [PATCH] New function org-speed-command-add for adding/modifying speed commands Shankar Rao 2022-05-03 10:24 ` Ihor Radchenko 2022-05-17 13:01 ` Shankar Rao [this message] 2022-05-18 13:12 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGEgU=j_idDyXGcnqTsqCzGYCFGGVzT4YrKYFoBeqrq3SAS9ng@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] New function org-speed-command-add for adding/modifying speed commands' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).