From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SLgwOPPwhGJf7gAAbAwnHQ (envelope-from ) for ; Wed, 18 May 2022 15:13:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sJsrOPPwhGLqwgAA9RJhRA (envelope-from ) for ; Wed, 18 May 2022 15:13:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D046353C6 for ; Wed, 18 May 2022 15:13:23 +0200 (CEST) Received: from localhost ([::1]:52758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrJUQ-0000bX-MK for larch@yhetil.org; Wed, 18 May 2022 09:13:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrJSa-0006V7-5L for emacs-orgmode@gnu.org; Wed, 18 May 2022 09:11:28 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:43548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrJSX-0007Uc-Tw for emacs-orgmode@gnu.org; Wed, 18 May 2022 09:11:27 -0400 Received: by mail-pf1-x430.google.com with SMTP id w200so2077809pfc.10 for ; Wed, 18 May 2022 06:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=INH5LJcqS9fdUxPsXKUMPjkPljLDyvMhCJ66aCS+9kk=; b=pI0n9KiWo2iKYvnfogPz7hB3SRzhx2yvlg+yom6mSO82KLYE+aeuAvW9I4hUZN2xxC 13kBJzXELdfhg14+Hn6yR5Ke+zgGKs5veTD52H1ty+/zUqFnJ43xEZkfuVgWyGNjIE9C FfR7XrjpjTLBMGxQI2nAKmTjMIsOpllfr64NJ0NnpbVtTIfrCvdpBzQimTR20XhOj3g7 b++9e9ypKHTbCciYkrD0+EBR+l6rwVx5vCFHKvng8HcPudj0ktZRCE+2YpvsDPQagQJE xjkNIvprdozgkxjO/Kudcn5tPHJTR2ru1MyMVtxmXrAvLj85aForMXJH4cGqE1kCZn1c FOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=INH5LJcqS9fdUxPsXKUMPjkPljLDyvMhCJ66aCS+9kk=; b=a/1NM0PPpGI4hP2FGMqxb0pnvE5HmjDz+FxWauij0nT23s6f7em3eGrIJGXtP1rAMA ZbSJG2S/Q1w70vfA1hqFhNyN5r7+AQZecaDXD4kclez9WEqzuM4gBxF7cvonYl47R9ZC 3lKHfpgPuENNnWE9YG0ZqoKLBCCCYSXliWtsj4AsZvUeW+s0oHOL2KsTu5jn1WpOcZRF s86JKpi7lp4YDl5NaDFEWal+Uubby88QFnWIiI38Fgp8mP8aJPPAz6U0WARPFlcOpmb7 zLPCKAF2vgDBJ02LSAKgfgoOIe/02T+By2A70wyJv2OvPGEq9/KIrVgZAoZbhoQ8vjCf qMCQ== X-Gm-Message-State: AOAM533wOPcnQ0onuiY8Z9vx8VjTrUUqu1+J+0cUVrIipxpCoLLMtAqa 4uaHMD/IIbq9DknuwnLsSQM= X-Google-Smtp-Source: ABdhPJxoWS2ZlLjdLu2Prdmc09UuOE2JQLq5azjnS8cYK2mT5chXY5CDtjycB41JoodfoajOIHe8Kg== X-Received: by 2002:a63:444a:0:b0:3f2:6670:d7b6 with SMTP id t10-20020a63444a000000b003f26670d7b6mr13967709pgk.309.1652879484434; Wed, 18 May 2022 06:11:24 -0700 (PDT) Received: from localhost ([134.73.242.163]) by smtp.gmail.com with ESMTPSA id m2-20020a629402000000b0050dc76281b4sm1921687pfe.142.2022.05.18.06.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:11:23 -0700 (PDT) From: Ihor Radchenko To: Shankar Rao Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] New function org-speed-command-add for adding/modifying speed commands In-Reply-To: References: <87bkwe52yj.fsf@localhost> Date: Wed, 18 May 2022 21:12:06 +0800 Message-ID: <87sfp70yu1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=yantar92@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652879603; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=INH5LJcqS9fdUxPsXKUMPjkPljLDyvMhCJ66aCS+9kk=; b=gWZ8enGmL4EKOHYI2nihdNoe8q26JsCykpmnatXoZskKy01G8pbKUtxel+aKMqJMhCZZ/M gtte3hTWtIXmewSAvMj0NmEVH6h+Sd8/hFxk6ErO2RM9ZgCQj/P9lxqUCgOvEV+r/IMQTq eCtHIBrGckMbb3q6zhZbjasEcdnx5Uk/xQcaIVviQdadIqeGYswtMFQD0H7Yznkh//wHvZ LCZhhZC0eHdfccQ2zavvMcZ3UzRPcnlN6eUo8kUoIWFo562ZpK9d9Egw1j4Bmz4rHLiqHv BXiS6/AxmohBQwqJzTVF3dr3zvrAznNrldhLILvzcDVDxPuTabZZeynFFXNvDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652879603; a=rsa-sha256; cv=none; b=ezjvZIOWnn/UZe3HFX1PcyD5VpsM/KOEw0EdxXdP1s+EZMd6z5p77bUEP/gqSparw4KLXq tsQFNQgLTecvJ8wCqiFtz14FPhpOey/d5ah3bOQ7vj/C2WyGW2bmU6GSy+YsLfjh/wHSVf mOG5DhsYPoH5I+ZU1KnHxnRkNk+jEfddlz6kZPeWnrhNQRn57cbou4dHLEnKSg3gdHO8av ADjzxe/GqyBB2Fe0Kq8ok6u9GGI+/cPvDFCJz+lfDmzcTGbKMVAngoaMUqflc4l6l816Qs rOMQ5Du1EBZ0YeWiNqZBtcRdmKTb7oQHGW+QqTorGgfrqbmTvdy/Twg1C5Oe/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pI0n9KiW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.35 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pI0n9KiW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9D046353C6 X-Spam-Score: -8.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: ycrp0rYypKvQ Shankar Rao writes: > Using ``org-speed-command-add'', I don't have to be concerned with > whether or not a given key is already present in > ``org-speed-commands''. Sure. However, the same can be achieved with fairly simple Elisp, as you saw in the earlier messages. I do not clearly see how a significant number of users can really benefit from this command. Most people will simply not notice it. Beginners should better use customize interface. Power users can just write elisp. The only way I can see the proposed approach useful is creating a unified framework to set various non-trivial Org options programatically (like org-agenda-custom-commands). I would be in favour of merging such framework, but not individual commands. Having convenience setters for some customisations, but not other will be just confusing. Org already has a huge number of cusomisations. Alternatively, if many people jump in and say that your idea is very for them, the patch can be merged. > I agree that ``org-speed-command-add'' has undefined behavior when > provided with only a descriptive headline as its first element. Would > you be more amenable to this command if it either ignored or > explicitly disallowed descriptive headline entries? There is not much point discussing this part given the above issue I raised. Best, Ihor