* [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
@ 2023-10-20 3:51 Vladimir Nikishkin
2023-10-20 7:37 ` Ihor Radchenko
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Nikishkin @ 2023-10-20 3:51 UTC (permalink / raw)
To: emacs-orgmode
Dear Org developers,
org-contrib has the following lines 206 and 207 in org-eldoc:
#+begin_src elisp
;;;###autoload
(add-hook 'org-mode-hook #'org-eldoc-load)
#+end_src
which set up that hook automatically when the package org-contrib is
installed.
that hook is, seemingly, incompatible with the recent org-element,
and in general it seems dubious to automatically add features from a
deprecated repo.
Could those lines be removed? If someone is interested in
patching/using/maintaining that code, he can probably try to refactor it
in a better way.
(In any case, it is probably better to add such hooks in the :hook
clause of use-package.)
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
2023-10-20 3:51 [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)] Vladimir Nikishkin
@ 2023-10-20 7:37 ` Ihor Radchenko
2023-10-20 7:39 ` Vladimir Nikishkin
0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2023-10-20 7:37 UTC (permalink / raw)
To: Vladimir Nikishkin; +Cc: emacs-orgmode
Vladimir Nikishkin <lockywolf@gmail.com> writes:
> org-contrib has the following lines 206 and 207 in org-eldoc:
> #+begin_src elisp
> ;;;###autoload
> (add-hook 'org-mode-hook #'org-eldoc-load)
> #+end_src
>
> which set up that hook automatically when the package org-contrib is
> installed.
>
> that hook is, seemingly, incompatible with the recent org-element,
May you elaborate about incompatibility?
> ... and in general it seems dubious to automatically add features from a
> deprecated repo.
This repo not deprecated, but rather not much maintained.
> Could those lines be removed? If someone is interested in
> patching/using/maintaining that code, he can probably try to refactor it
> in a better way.
>
> (In any case, it is probably better to add such hooks in the :hook
> clause of use-package.)
That would constitute incompatible change for the existing users.
Although, autoload may cause org-eldoc to be loaded for users of
org-contrib, who are not interested in org-eldoc.
What we might do as a compromise is removing the autoload cookie only
and leaving the (add-hook ...) to be executed upon (require 'org-eldoc).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
2023-10-20 7:37 ` Ihor Radchenko
@ 2023-10-20 7:39 ` Vladimir Nikishkin
2023-10-20 7:49 ` Ihor Radchenko
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Nikishkin @ 2023-10-20 7:39 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Ihor Radchenko <yantar92@posteo.net> writes:
> Vladimir Nikishkin <lockywolf@gmail.com> writes:
>
>> org-contrib has the following lines 206 and 207 in org-eldoc:
>> #+begin_src elisp
>> ;;;###autoload
>> (add-hook 'org-mode-hook #'org-eldoc-load)
>> #+end_src
>>
>> which set up that hook automatically when the package org-contrib is
>> installed.
>>
>> that hook is, seemingly, incompatible with the recent org-element,
>
> May you elaborate about incompatibility?
>
Yes. With org-eldoc loaded, and having a property '#+date: unpublished'
in an org file, I am having the '*Messages*' buffer filled with
#+begin_src elisp
⛔ Warning (org-element-cache): org-element--cache: Org parser error in 2015_Passwords.org.rclignore::53653. Resetting.
The error was: (error "Invalid search bound (wrong side of point)")
Backtrace:
" backtrace-to-string(nil)
org-element-at-point()
org-eldoc-get-src-lang()
org-eldoc-documentation-function(#f(compiled-function (string &rest plist) #<bytecode 0x76e7a7311110465>))
#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_17>(org-eldoc-documentation-function)
eldoc-documentation-default()
eldoc--invoke-strategy(nil)
eldoc-print-current-symbol-info()
#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_12>()
apply(#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_12> nil)
timer-event-handler([t 0 0 500000 nil #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_12> nil idle 0 nil])
"
Please report this to Org mode mailing list (M-x org-submit-bug-report).
#+end_src
>> Could those lines be removed? If someone is interested in
>> patching/using/maintaining that code, he can probably try to refactor it
>> in a better way.
>>
>> (In any case, it is probably better to add such hooks in the :hook
>> clause of use-package.)
>
> That would constitute incompatible change for the existing users.
> Although, autoload may cause org-eldoc to be loaded for users of
> org-contrib, who are not interested in org-eldoc.
> What we might do as a compromise is removing the autoload cookie only
> and leaving the (add-hook ...) to be executed upon (require 'org-eldoc).
Yes, maybe that is even better. Why would one (require 'org-eldoc) with
no intention of using it?
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
2023-10-20 7:39 ` Vladimir Nikishkin
@ 2023-10-20 7:49 ` Ihor Radchenko
2023-11-10 1:22 ` Vladimir Nikishkin
0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2023-10-20 7:49 UTC (permalink / raw)
To: Vladimir Nikishkin; +Cc: emacs-orgmode
Vladimir Nikishkin <lockywolf@gmail.com> writes:
>> May you elaborate about incompatibility?
>>
>
> Yes. With org-eldoc loaded, and having a property '#+date: unpublished'
> in an org file, I am having the '*Messages*' buffer filled with
> #+begin_src elisp
> ⛔ Warning (org-element-cache): org-element--cache: Org parser error in 2015_Passwords.org.rclignore::53653. Resetting.
> The error was: (error "Invalid search bound (wrong side of point)")
> Backtrace:
> " backtrace-to-string(nil)
> org-element-at-point()
This has nothing to do with eldoc.
If you can reproduce this problem consistently, may you create a minimal
example as described in https://orgmode.org/manual/Feedback.html#Feedback ?
>> That would constitute incompatible change for the existing users.
>> Although, autoload may cause org-eldoc to be loaded for users of
>> org-contrib, who are not interested in org-eldoc.
>> What we might do as a compromise is removing the autoload cookie only
>> and leaving the (add-hook ...) to be executed upon (require 'org-eldoc).
>
> Yes, maybe that is even better. Why would one (require 'org-eldoc) with
> no intention of using it?
Fixed, on master.
https://git.sr.ht/~bzg/org-contrib/commit/6e208c87bf6ede9251c9c5733b81b004b1e44966
As for `require', it is not so simple. Things like C-h f can trigger
loading libraries. But addressing such peculiarities is beyond the level
of maintenance we can provide for org-contrib.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
2023-10-20 7:49 ` Ihor Radchenko
@ 2023-11-10 1:22 ` Vladimir Nikishkin
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Nikishkin @ 2023-11-10 1:22 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Ihor Radchenko <yantar92@posteo.net> writes:
> Vladimir Nikishkin <lockywolf@gmail.com> writes:
>
>>> May you elaborate about incompatibility?
>>>
>>
>> Yes. With org-eldoc loaded, and having a property '#+date: unpublished'
>> in an org file, I am having the '*Messages*' buffer filled with
>> #+begin_src elisp
>> ⛔ Warning (org-element-cache): org-element--cache: Org parser error in 2015_Passwords.org.rclignore::53653. Resetting.
>> The error was: (error "Invalid search bound (wrong side of point)")
>> Backtrace:
>> " backtrace-to-string(nil)
>> org-element-at-point()
>
> This has nothing to do with eldoc.
> If you can reproduce this problem consistently, may you create a minimal
> example as described in https://orgmode.org/manual/Feedback.html#Feedback ?
I found and fixed this problem.
It was actually unrelated to bare org, it was due to my experiments with
org-ts-mode. Sorry for the confusion.
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-10 1:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 3:51 [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)] Vladimir Nikishkin
2023-10-20 7:37 ` Ihor Radchenko
2023-10-20 7:39 ` Vladimir Nikishkin
2023-10-20 7:49 ` Ihor Radchenko
2023-11-10 1:22 ` Vladimir Nikishkin
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).