From: Ihor Radchenko <yantar92@posteo.net>
To: Vladimir Nikishkin <lockywolf@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)]
Date: Fri, 20 Oct 2023 07:37:00 +0000 [thread overview]
Message-ID: <87pm19d9sz.fsf@localhost> (raw)
In-Reply-To: <871qdq54ol.fsf@laptop.lockywolf.net>
Vladimir Nikishkin <lockywolf@gmail.com> writes:
> org-contrib has the following lines 206 and 207 in org-eldoc:
> #+begin_src elisp
> ;;;###autoload
> (add-hook 'org-mode-hook #'org-eldoc-load)
> #+end_src
>
> which set up that hook automatically when the package org-contrib is
> installed.
>
> that hook is, seemingly, incompatible with the recent org-element,
May you elaborate about incompatibility?
> ... and in general it seems dubious to automatically add features from a
> deprecated repo.
This repo not deprecated, but rather not much maintained.
> Could those lines be removed? If someone is interested in
> patching/using/maintaining that code, he can probably try to refactor it
> in a better way.
>
> (In any case, it is probably better to add such hooks in the :hook
> clause of use-package.)
That would constitute incompatible change for the existing users.
Although, autoload may cause org-eldoc to be loaded for users of
org-contrib, who are not interested in org-eldoc.
What we might do as a compromise is removing the autoload cookie only
and leaving the (add-hook ...) to be executed upon (require 'org-eldoc).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-10-20 7:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 3:51 [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)] Vladimir Nikishkin
2023-10-20 7:37 ` Ihor Radchenko [this message]
2023-10-20 7:39 ` Vladimir Nikishkin
2023-10-20 7:49 ` Ihor Radchenko
2023-11-10 1:22 ` Vladimir Nikishkin
2023-12-26 9:27 ` Vladimir Nikishkin
2023-12-26 12:12 ` Ihor Radchenko
2023-12-26 12:13 ` Vladimir Nikishkin
2023-12-26 12:23 ` Ihor Radchenko
2023-12-26 12:26 ` Vladimir Nikishkin
2023-12-26 12:34 ` Vladimir Nikishkin
2023-12-26 13:22 ` Ihor Radchenko
2023-12-26 13:25 ` Vladimir Nikishkin
2023-12-26 13:31 ` Ihor Radchenko
2023-12-26 13:59 ` Vladimir Nikishkin
2023-12-26 14:33 ` Ihor Radchenko
2023-12-26 14:45 ` Vladimir Nikishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm19d9sz.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=lockywolf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).