* [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]
@ 2024-03-17 19:28 Damien Cassou
2024-03-17 19:34 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: Damien Cassou @ 2024-03-17 19:28 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
In my unit tests, I don't want to see any LaTeX-related warnings because
they don't use that. I thus changed my unit-tests to force :with-latex
to be 'verbatim. But this still requires this patch.
Emacs : GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)
Package: Org mode version 9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]
2024-03-17 19:28 [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)] Damien Cassou
@ 2024-03-17 19:34 ` Ihor Radchenko
2024-03-17 21:06 ` Damien Cassou
0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2024-03-17 19:34 UTC (permalink / raw)
To: Damien Cassou; +Cc: emacs-orgmode
Damien Cassou <damien@cassou.me> writes:
> In my unit tests, I don't want to see any LaTeX-related warnings because
> they don't use that. I thus changed my unit-tests to force :with-latex
> to be 'verbatim. But this still requires this patch.
It would be nice to attach the patch :)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]
2024-03-17 19:34 ` Ihor Radchenko
@ 2024-03-17 21:06 ` Damien Cassou
2024-03-19 14:24 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: Damien Cassou @ 2024-03-17 21:06 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
Ihor Radchenko <yantar92@posteo.net> writes:
> It would be nice to attach the patch :)
I'm sorry. Here it is.
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-odt-Avoid-warning-when-everything-is-fine.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]
From 9dd17fcb7c774f148166d999fd1d021dae9fda3b Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Sun, 17 Mar 2024 20:24:59 +0100
Subject: [PATCH] ox-odt: Avoid warning when everything is fine
* lisp/ox-odt.el (org-odt--translate-latex-fragments): When
processing-type is already 'verbatim, no need to print any warning.
---
lisp/ox-odt.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 666d5da1a..3f1f1a5a8 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -3728,6 +3728,7 @@ (defun org-odt--translate-latex-fragments (tree _backend info)
(if (eq processing-type 'dvipng) "dvipng" "convert") "" t))
(setq warning "`org-odt-with-latex': LaTeX to PNG converter not available. Falling back to verbatim.")
(setq processing-type 'verbatim)))
+ (verbatim) ;; nothing to do
(otherwise
(setq warning "`org-odt-with-latex': Unknown LaTeX option. Forcing verbatim.")
(setq processing-type 'verbatim)))
--
2.43.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]
2024-03-17 21:06 ` Damien Cassou
@ 2024-03-19 14:24 ` Ihor Radchenko
0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-03-19 14:24 UTC (permalink / raw)
To: Damien Cassou; +Cc: emacs-orgmode
Damien Cassou <damien@cassou.me> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>> It would be nice to attach the patch :)
>
> ...
> Subject: [PATCH] ox-odt: Avoid warning when everything is fine
>
> * lisp/ox-odt.el (org-odt--translate-latex-fragments): When
> processing-type is already 'verbatim, no need to print any warning.
Thanks!
Applied, onto main.
Fixed.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2381c7b88
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-19 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-17 19:28 [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)] Damien Cassou
2024-03-17 19:34 ` Ihor Radchenko
2024-03-17 21:06 ` Damien Cassou
2024-03-19 14:24 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).