emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Damien Cassou <damien@cassou.me>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]
Date: Sun, 17 Mar 2024 22:06:30 +0100	[thread overview]
Message-ID: <8734sofu09.fsf@cassou.me> (raw)
In-Reply-To: <87edc8y7mq.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Ihor Radchenko <yantar92@posteo.net> writes:
> It would be nice to attach the patch :)

I'm sorry. Here it is.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-odt-Avoid-warning-when-everything-is-fine.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]

From 9dd17fcb7c774f148166d999fd1d021dae9fda3b Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Sun, 17 Mar 2024 20:24:59 +0100
Subject: [PATCH] ox-odt: Avoid warning when everything is fine

* lisp/ox-odt.el (org-odt--translate-latex-fragments): When
processing-type is already 'verbatim, no need to print any warning.
---
 lisp/ox-odt.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 666d5da1a..3f1f1a5a8 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -3728,6 +3728,7 @@ (defun org-odt--translate-latex-fragments (tree _backend info)
 		     (if (eq processing-type 'dvipng) "dvipng" "convert") "" t))
 	 (setq warning "`org-odt-with-latex': LaTeX to PNG converter not available.  Falling back to verbatim.")
 	 (setq processing-type 'verbatim)))
+      (verbatim) ;; nothing to do
       (otherwise
        (setq warning "`org-odt-with-latex': Unknown LaTeX option.  Forcing verbatim.")
        (setq processing-type 'verbatim)))
-- 
2.43.2


  reply	other threads:[~2024-03-17 21:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-17 19:28 [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)] Damien Cassou
2024-03-17 19:34 ` Ihor Radchenko
2024-03-17 21:06   ` Damien Cassou [this message]
2024-03-19 14:24     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734sofu09.fsf@cassou.me \
    --to=damien@cassou.me \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).