emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Byte compiler warnings
@ 2011-10-22 14:15 Achim Gratz
  2011-10-22 14:31 ` Bastien
  2011-10-24 23:46 ` Andrei Jirnyi
  0 siblings, 2 replies; 6+ messages in thread
From: Achim Gratz @ 2011-10-22 14:15 UTC (permalink / raw)
  To: emacs-orgmode


Recently the byte compiler has become increasingly dissatisfied with the
orgmode code again... :-)

Emacs24 complains about these:

In org-agenda-get-blocks:
org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
org-agenda.el:5434:20:Warning: reference to free variable `category-pos'

That actually has been there for a while.

In org-edit-src-code:
org-src.el:295:14:Warning: reference to free variable `eq'

That's most likely a bug involving a comparison, in any case if "eq" really is a variable it
surely needs a different name.


In org-babel-get-lob-one-liner-matches:
ob.el:191:21:Warning: reference to free variable
    `org-babel-inline-lob-one-liner-regexp'

That one is a bit older IIRC.


In org-babel-execute:shen:
ob-shen.el:68:32:Warning: reference to free variable `result-params'
ob-shen.el:72:19:Warning: reference to free variable `result'

I guess Eric knows what to do with this.


In end of data:
org.el:20874:1:Warning: the function `cdlatex-compute-tables' is not known to
    be defined.

I don't know if a package needs to be required or the function declared.


Emacs23 additionally complains about:

In org-mode:
org.el:4870:9:Warning: assignment to free variable `bidi-paragraph-direction'

In end of data:
org.el:20874:1:Warning: the function `format-spec' might not be defined at
    runtime.

It looks like these functions don't exist in Emacs23 and need to be
protected via version-dependent wrappers.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Byte compiler warnings
  2011-10-22 14:15 Byte compiler warnings Achim Gratz
@ 2011-10-22 14:31 ` Bastien
  2011-10-22 14:59   ` Achim Gratz
  2011-10-24 23:46 ` Andrei Jirnyi
  1 sibling, 1 reply; 6+ messages in thread
From: Bastien @ 2011-10-22 14:31 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Recently the byte compiler has become increasingly dissatisfied with the
> orgmode code again... :-)
>
> Emacs24 complains about these:
>
> In org-agenda-get-blocks:
> org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
> org-agenda.el:5434:20:Warning: reference to free variable
> `category-pos'

I just fixed this.

> That actually has been there for a while.

Yes, my bad.

> In org-edit-src-code:
> org-src.el:295:14:Warning: reference to free variable `eq'

This is also fixed.

> That's most likely a bug involving a comparison, in any case if "eq" really is a variable it
> surely needs a different name.
>
> In org-babel-get-lob-one-liner-matches:
> ob.el:191:21:Warning: reference to free variable
>     `org-babel-inline-lob-one-liner-regexp'

Fixed.

> In org-babel-execute:shen:
> ob-shen.el:68:32:Warning: reference to free variable `result-params'
> ob-shen.el:72:19:Warning: reference to free variable `result'

I expect Eric will take care of this.
>
> In end of data:
> org.el:20874:1:Warning: the function `cdlatex-compute-tables' is not known to
>     be defined.

Fixed.

> I don't know if a package needs to be required or the function
> declared.

The function needs to be declared.

> Emacs23 additionally complains about:
>
> In org-mode:
> org.el:4870:9:Warning: assignment to free variable `bidi-paragraph-direction'
>
> In end of data:
> org.el:20874:1:Warning: the function `format-spec' might not be defined at
>     runtime.
>
> It looks like these functions don't exist in Emacs23 and need to be
> protected via version-dependent wrappers.

On my todo list.

Thanks for the careful check!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Byte compiler warnings
  2011-10-22 14:31 ` Bastien
@ 2011-10-22 14:59   ` Achim Gratz
  2011-10-23 20:46     ` Bastien
  0 siblings, 1 reply; 6+ messages in thread
From: Achim Gratz @ 2011-10-22 14:59 UTC (permalink / raw)
  To: emacs-orgmode

Hi Bastien,

thanks for fixing.  I've just pulled again.

>> In org-agenda-get-blocks:
>> org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
>> org-agenda.el:5434:20:Warning: reference to free variable
>> `category-pos'
>
> I just fixed this.

I'm still getting the same error with commit e0c1855 included.  The rest
of your fixes did quell the warnings from the byte compiler.



Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Byte compiler warnings
  2011-10-22 14:59   ` Achim Gratz
@ 2011-10-23 20:46     ` Bastien
  0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2011-10-23 20:46 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

>>> In org-agenda-get-blocks:
>>> org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
>>> org-agenda.el:5434:20:Warning: reference to free variable
>>> `category-pos'
>>
>> I just fixed this.
>
> I'm still getting the same error with commit e0c1855 included.  The rest
> of your fixes did quell the warnings from the byte compiler.

You're right, I've just fixed this for good.

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Byte compiler warnings
  2011-10-22 14:15 Byte compiler warnings Achim Gratz
  2011-10-22 14:31 ` Bastien
@ 2011-10-24 23:46 ` Andrei Jirnyi
  2011-10-28 15:27   ` Bastien
  1 sibling, 1 reply; 6+ messages in thread
From: Andrei Jirnyi @ 2011-10-24 23:46 UTC (permalink / raw)
  To: emacs-orgmode

A few warnings from Emacs 23.2.1 here:

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-C.el at Mon Oct 
24 18:20:36 2011
Entering directory `/home/xxxxxx/.emacs.d/elpa/org-20111024/'

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-calc.el at Mon 
Oct 24 18:20:36 2011

In end of data:
ob-calc.el:105:1:Warning: the following functions are not known to be 
defined:
    calc-store-into, calc-recall, math-evaluate-expr

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-shen.el at Mon 
Oct 24 18:20:38 2011

In org-babel-execute:shen:
ob-shen.el:68:32:Warning: reference to free variable `result-params'
ob-shen.el:72:19:Warning: reference to free variable `result'

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-agenda.el at 
Mon Oct 24 18:20:39 2011

In org-agenda-list:
org-agenda.el:3555:26:Warning: `org-agenda-ndays' is an obsolete variable 
(as
    of Emacs 24.1); use `org-agenda-span' instead.

In org-agenda-get-todos:
org-agenda.el:4596:26:Warning: reference to free variable
    `org-heading-keyword-regexp-format'

In org-agenda-goto-today:
org-agenda.el:6410:59:Warning: `org-agenda-ndays' is an obsolete variable 
(as
    of Emacs 24.1); use `org-agenda-span' instead.

In org-agenda-reset-view:
org-agenda.el:6495:36:Warning: `org-agenda-ndays' is an obsolete variable 
(as
    of Emacs 24.1); use `org-agenda-span' instead.

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-colview.el at 
Mon Oct 24 18:20:41 2011

In org-columns-capture-view:
org-colview.el:1155:32:Warning: reference to free variable
    `org-heading-keyword-regexp-format'
org-colview.el:1160:33:Warning: reference to free variable
    `org-heading-regexp'

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-compat.el at 
Mon Oct 24 18:20:41 2011

In org-find-library-name:
org-compat.el:341:14:Warning: find-library called with 3 arguments, but
    accepts only 1

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-docbook.el at 
Mon Oct 24 18:20:41 2011

In org-export-as-docbook:
org-docbook.el:502:31:Warning: reference to free variable
    `org-heading-keyword-regexp-format'

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-exp.el at Mon 
Oct 24 18:20:42 2011

In org-export-protect-quoted-subtrees:
org-exp.el:1641:31:Warning: reference to free variable
    `org-heading-keyword-regexp-format'

In org-export-remove-comment-blocks-and-subtrees:
org-exp.el:1936:31:Warning: reference to free variable
    `org-heading-keyword-regexp-format'

Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-html.el at Mon 
Oct 24 18:20:47 2011

In org-export-as-html:
org-html.el:1179:31:Warning: reference to free variable
    `org-heading-keyword-regexp-format'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Byte compiler warnings
  2011-10-24 23:46 ` Andrei Jirnyi
@ 2011-10-28 15:27   ` Bastien
  0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2011-10-28 15:27 UTC (permalink / raw)
  To: Andrei Jirnyi; +Cc: emacs-orgmode

Hi Andrei,

Andrei Jirnyi <a-jirnyi@northwestern.edu> writes:

> A few warnings from Emacs 23.2.1 here:

Thanks.  I fixed most of them.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-C.el at Mon Oct 
> 24 18:20:36 2011
> Entering directory `/home/xxxxxx/.emacs.d/elpa/org-20111024/'
>
> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-calc.el at Mon 
> Oct 24 18:20:36 2011
>
> In end of data:
> ob-calc.el:105:1:Warning: the following functions are not known to be 
> defined:
>     calc-store-into, calc-recall, math-evaluate-expr

Fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/ob-shen.el at Mon 
> Oct 24 18:20:38 2011
>
> In org-babel-execute:shen:
> ob-shen.el:68:32:Warning: reference to free variable `result-params'
> ob-shen.el:72:19:Warning: reference to free variable `result'

Not fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-agenda.el at 
> Mon Oct 24 18:20:39 2011
>
> In org-agenda-list:
> org-agenda.el:3555:26:Warning: `org-agenda-ndays' is an obsolete variable 
> (as
>     of Emacs 24.1); use `org-agenda-span' instead.

Not fixed.

> In org-agenda-get-todos:
> org-agenda.el:4596:26:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'

Fixed.

> In org-agenda-goto-today:
> org-agenda.el:6410:59:Warning: `org-agenda-ndays' is an obsolete variable 
> (as
>     of Emacs 24.1); use `org-agenda-span' instead.
>
> In org-agenda-reset-view:
> org-agenda.el:6495:36:Warning: `org-agenda-ndays' is an obsolete variable 
> (as
>     of Emacs 24.1); use `org-agenda-span' instead.

Not fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-colview.el at 
> Mon Oct 24 18:20:41 2011
>
> In org-columns-capture-view:
> org-colview.el:1155:32:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'
> org-colview.el:1160:33:Warning: reference to free variable
>     `org-heading-regexp'

Fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-compat.el at 
> Mon Oct 24 18:20:41 2011
>
> In org-find-library-name:
> org-compat.el:341:14:Warning: find-library called with 3 arguments, but
>     accepts only 1

No fix needed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-docbook.el at 
> Mon Oct 24 18:20:41 2011
>
> In org-export-as-docbook:
> org-docbook.el:502:31:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'

Fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-exp.el at Mon 
> Oct 24 18:20:42 2011
>
> In org-export-protect-quoted-subtrees:
> org-exp.el:1641:31:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'
>
> In org-export-remove-comment-blocks-and-subtrees:
> org-exp.el:1936:31:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'

Fixed.

> Compiling file /home/xxxxxx/.emacs.d/elpa/org-20111024/org-html.el at Mon 
> Oct 24 18:20:47 2011
>
> In org-export-as-html:
> org-html.el:1179:31:Warning: reference to free variable
>     `org-heading-keyword-regexp-format'

Fixed.

Please report other problems.

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-28 15:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-22 14:15 Byte compiler warnings Achim Gratz
2011-10-22 14:31 ` Bastien
2011-10-22 14:59   ` Achim Gratz
2011-10-23 20:46     ` Bastien
2011-10-24 23:46 ` Andrei Jirnyi
2011-10-28 15:27   ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).