emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Byte compiler warnings
Date: Sat, 22 Oct 2011 16:31:25 +0200	[thread overview]
Message-ID: <87ipnhhzcy.fsf@gnu.org> (raw)
In-Reply-To: <87ty712jua.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 22 Oct 2011 16:15:41 +0200")

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Recently the byte compiler has become increasingly dissatisfied with the
> orgmode code again... :-)
>
> Emacs24 complains about these:
>
> In org-agenda-get-blocks:
> org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
> org-agenda.el:5434:20:Warning: reference to free variable
> `category-pos'

I just fixed this.

> That actually has been there for a while.

Yes, my bad.

> In org-edit-src-code:
> org-src.el:295:14:Warning: reference to free variable `eq'

This is also fixed.

> That's most likely a bug involving a comparison, in any case if "eq" really is a variable it
> surely needs a different name.
>
> In org-babel-get-lob-one-liner-matches:
> ob.el:191:21:Warning: reference to free variable
>     `org-babel-inline-lob-one-liner-regexp'

Fixed.

> In org-babel-execute:shen:
> ob-shen.el:68:32:Warning: reference to free variable `result-params'
> ob-shen.el:72:19:Warning: reference to free variable `result'

I expect Eric will take care of this.
>
> In end of data:
> org.el:20874:1:Warning: the function `cdlatex-compute-tables' is not known to
>     be defined.

Fixed.

> I don't know if a package needs to be required or the function
> declared.

The function needs to be declared.

> Emacs23 additionally complains about:
>
> In org-mode:
> org.el:4870:9:Warning: assignment to free variable `bidi-paragraph-direction'
>
> In end of data:
> org.el:20874:1:Warning: the function `format-spec' might not be defined at
>     runtime.
>
> It looks like these functions don't exist in Emacs23 and need to be
> protected via version-dependent wrappers.

On my todo list.

Thanks for the careful check!

-- 
 Bastien

  reply	other threads:[~2011-10-22 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22 14:15 Byte compiler warnings Achim Gratz
2011-10-22 14:31 ` Bastien [this message]
2011-10-22 14:59   ` Achim Gratz
2011-10-23 20:46     ` Bastien
2011-10-24 23:46 ` Andrei Jirnyi
2011-10-28 15:27   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipnhhzcy.fsf@gnu.org \
    --to=bzg@altern.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).