* Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)]
@ 2018-03-04 0:01 Luke
2018-03-06 9:16 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Luke @ 2018-03-04 0:01 UTC (permalink / raw)
To: emacs-orgmode
The face of the clocked time does not seem to change when the clock
overruns (typically it changes to a red background).
I'm no lisp expert, but after digging around in the code it looks like
the problem is in org-clock-get-clock-string():
662 (defun org-clock-get-clock-string ()
663 "Form a clock-string, that will be shown in the mode line.
664 If an effort estimate was defined for the current item, use
665 01:30/01:50 format (clocked/estimated).
666 If not, show simply the clocked time like 01:50."
667 (let ((clocked-time (org-clock-get-clocked-time)))
668 (propertize
669 (if org-clock-effort
...
683 'face 'org-mode-line-clock)))
It seems like the call to propertize (on line #668) is overwriting the
face ('org-mode-line-clock-overrun) of the resulting string with
'org-mode-line-clock. I think this change was introduced in commit
6655429b8d.
Emacs : GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
of 2017-09-21 on lcy01-07, modified by Debian
Package: Org mode version 9.1.7 (release_9.1.7-466-ga16590.dirty @
/home/luke/elisp/org-mode/lisp/)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)]
2018-03-04 0:01 Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)] Luke
@ 2018-03-06 9:16 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-03-06 9:16 UTC (permalink / raw)
To: Luke; +Cc: emacs-orgmode
Hello,
Luke <mideniko1234-org@yahoo.co.uk> writes:
> The face of the clocked time does not seem to change when the clock
> overruns (typically it changes to a red background).
>
> I'm no lisp expert, but after digging around in the code it looks like
> the problem is in org-clock-get-clock-string():
>
> 662 (defun org-clock-get-clock-string ()
> 663 "Form a clock-string, that will be shown in the mode line.
> 664 If an effort estimate was defined for the current item, use
> 665 01:30/01:50 format (clocked/estimated).
> 666 If not, show simply the clocked time like 01:50."
> 667 (let ((clocked-time (org-clock-get-clocked-time)))
> 668 (propertize
> 669 (if org-clock-effort
>
> ...
>
> 683 'face 'org-mode-line-clock)))
>
> It seems like the call to propertize (on line #668) is overwriting the
> face ('org-mode-line-clock-overrun) of the resulting string with
> 'org-mode-line-clock. I think this change was introduced in commit
> 6655429b8d.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-04 0:01 Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)] Luke
2018-03-06 9:16 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).