From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Luke <mideniko1234-org@yahoo.co.uk>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)]
Date: Tue, 06 Mar 2018 10:16:53 +0100 [thread overview]
Message-ID: <87po4h36nu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <p7fct9$9t3$1@blaine.gmane.org> (Luke's message of "Sun, 4 Mar 2018 08:01:43 +0800")
Hello,
Luke <mideniko1234-org@yahoo.co.uk> writes:
> The face of the clocked time does not seem to change when the clock
> overruns (typically it changes to a red background).
>
> I'm no lisp expert, but after digging around in the code it looks like
> the problem is in org-clock-get-clock-string():
>
> 662 (defun org-clock-get-clock-string ()
> 663 "Form a clock-string, that will be shown in the mode line.
> 664 If an effort estimate was defined for the current item, use
> 665 01:30/01:50 format (clocked/estimated).
> 666 If not, show simply the clocked time like 01:50."
> 667 (let ((clocked-time (org-clock-get-clocked-time)))
> 668 (propertize
> 669 (if org-clock-effort
>
> ...
>
> 683 'face 'org-mode-line-clock)))
>
> It seems like the call to propertize (on line #668) is overwriting the
> face ('org-mode-line-clock-overrun) of the resulting string with
> 'org-mode-line-clock. I think this change was introduced in commit
> 6655429b8d.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2018-03-06 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 0:01 Bug: Mode line face is not updated when clock overruns [9.1.7 (release_9.1.7-466-ga16590.dirty @ /home/luke/elisp/org-mode/lisp/)] Luke
2018-03-06 9:16 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po4h36nu.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mideniko1234-org@yahoo.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).