emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [babel] Export problem (Wrong type argument: consp, nil)
Date: Fri, 16 Sep 2011 09:25:56 -0600	[thread overview]
Message-ID: <87obykpjjx.fsf@gmail.com> (raw)
In-Reply-To: 80litoaj9f.fsf@somewhere.org

Hi

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Eric,
>
> Eric Schulte wrote:
>> Thanks for working on this test, I look forward to adding it once it is
>> completed.
>
> As promised, a patch for checking that vars with no default value will
> generate an error with a full explanation.
>
> I edited 2 files:
> - lisp/test-ob.el
> - examples/babel.org
>

Great! Thanks for contributing these test cases.  They are now applied
and are passing.

>
> Tell me if this is following your expected way of receiving patches. I believe
> so, but tell me anything that would not have been done correctly...
>

Yes, I do prefer these format of patch (i.e., generated using git
format-patch), however I would prefer if you only sent a single patch
for all changed files, rather than splitting the commit up into two
patches.

Thanks -- Eric

>
> Best regards,
>   Seb

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

     prev parent reply	other threads:[~2011-09-16 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 15:15 [babel] Export problem (Wrong type argument: consp, nil) Sebastien Vauban
2011-09-08 17:33 ` Eric Schulte
2011-09-14  8:52   ` Sebastien Vauban
2011-09-14 11:44     ` Martyn Jago
2011-09-15 15:10     ` Eric Schulte
2011-09-16  9:57       ` Sebastien Vauban
2011-09-16 10:12       ` Sebastien Vauban
2011-09-16 15:25         ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obykpjjx.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).