From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [babel] Export problem (Wrong type argument: consp, nil) Date: Fri, 16 Sep 2011 09:25:56 -0600 Message-ID: <87obykpjjx.fsf@gmail.com> References: <80litzcbg1.fsf@somewhere.org> <87hb4ndj1f.fsf@gmail.com> <80y5xrld4x.fsf@somewhere.org> <87wrd9hkfv.fsf@gmail.com> <80litoaj9f.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:40364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4amd-0002JB-St for emacs-orgmode@gnu.org; Fri, 16 Sep 2011 11:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4amc-00015z-Iu for emacs-orgmode@gnu.org; Fri, 16 Sep 2011 11:56:55 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:64023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4amc-00014v-C4 for emacs-orgmode@gnu.org; Fri, 16 Sep 2011 11:56:54 -0400 Received: by mail-iy0-f169.google.com with SMTP id n33so3441604iae.0 for ; Fri, 16 Sep 2011 08:56:54 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: emacs-orgmode@gnu.org Hi "Sebastien Vauban" writes: > Hi Eric, > > Eric Schulte wrote: >> Thanks for working on this test, I look forward to adding it once it is >> completed. > > As promised, a patch for checking that vars with no default value will > generate an error with a full explanation. > > I edited 2 files: > - lisp/test-ob.el > - examples/babel.org > Great! Thanks for contributing these test cases. They are now applied and are passing. > > Tell me if this is following your expected way of receiving patches. I believe > so, but tell me anything that would not have been done correctly... > Yes, I do prefer these format of patch (i.e., generated using git format-patch), however I would prefer if you only sent a single patch for all changed files, rather than splitting the commit up into two patches. Thanks -- Eric > > Best regards, > Seb -- Eric Schulte http://cs.unm.edu/~eschulte/